Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update type annotations for compatiblity with prometheus_client 0.14 #12389

Merged
merged 3 commits into from Apr 6, 2022
Merged

Update type annotations for compatiblity with prometheus_client 0.14 #12389

merged 3 commits into from Apr 6, 2022

Commits on Apr 6, 2022

  1. Update type annotations for compatiblity with prometheus_client 0.14 

    Principally, `prometheus_client.REGISTRY.register` now requires its argument to
extend `prometheus_client.Collector`.

Additionally, `Gauge.set` is now annotated so that passing `Optional[int]`
causes an error.
    @richvdh
    richvdh committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    fa51575 View commit details
    Browse the repository at this point in the history

  2. fix circular imports

    @richvdh
    richvdh committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    537cf44 View commit details
    Browse the repository at this point in the history

  3. import Literal from typing_extensions 

    This was added to stdlib `typing` module in 3.8.
    David Robertson committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    73e6123 View commit details
    Browse the repository at this point in the history