Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Don't return end from /messages if there are no more events #12903

Merged
merged 6 commits into from
May 30, 2022
Merged

Don't return end from /messages if there are no more events #12903

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
831d7b1
Don't return end if no more events
Vetchu May 28, 2022
700e057
Add changelog.d entry
Vetchu May 29, 2022
2e99b9d
add missing dot
Vetchu May 29, 2022
09c891e
Update changelog.d/12903.bugfix
Vetchu May 30, 2022
a530133
Add no events no end handler back, add some comments for clarification.
Vetchu May 30, 2022
1e8c19e
Update synapse/handlers/pagination.py
richvdh May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/12903.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not return end attribute when there are no more events.
Vetchu marked this conversation as resolved.
Show resolved Hide resolved
1 change: 0 additions & 1 deletion synapse/handlers/pagination.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,6 @@ async def get_messages(
return {
"chunk": [],
"start": await from_token.to_string(self.store),
"end": await next_token.to_string(self.store),
Vetchu marked this conversation as resolved.
Show resolved Hide resolved
}

state = None
Expand Down