`synapse.api.auth.Auth` cleanup: make permission-related methods use `Requester` instead of the `UserID` #13024

sandhose · 2022-06-10T16:11:22Z

This changes all the permission-related methods to rely on the Requester instead of the UserID. This is a first step towards enabling scoped access tokens at some point, since I expect the Requester to have scope-related informations in it.

It also changes methods which figure out the user/device/appservice out of the access token to return a Requester instead of something else. This avoids having store-related objects in the methods signatures.

I've added comments on some of those changes that are not so obvious to help with review.

It can be reviewed commit by commit.

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Pull request includes a sign off
Code style is correct
(run the linters)

sandhose

A bunch of comments to help with review

sandhose · 2022-06-15T09:25:24Z

synapse/api/auth.py


    async def get_user_by_access_token(
        self,
        token: str,
        allow_expired: bool = False,
-    ) -> TokenLookupResult:
+        mark_as_used: bool = False,


I've added this parameter because I moved the mark_access_token_as_used here, because the token_used exists in the TokenLookupResult but not in the Requester ; but there are places where we're calling get_user_by_access_token and don't really want to mark the token as used in those cases (although I guess we could?)

yeah this is fine, though I wonder if the default should be True ?

It might be better to remove this parameter altogether? (see my comment below)

I got rid of this parameter in 1670733

synapse/handlers/auth.py

synapse/handlers/register.py

synapse/handlers/typing.py

synapse/rest/client/register.py

sandhose · 2022-06-15T09:41:34Z

synapse/server_notices/server_notices_manager.py

@@ -244,7 +244,7 @@ async def _update_notice_user_profile_if_changed(
        assert self.server_notices_mxid is not None

        notice_user_data_in_room = await self._message_handler.get_room_data(
-            self.server_notices_mxid,
+            create_requester(self.server_notices_mxid),


Note that it's the only place outside of tests where I have to create a requester on the fly because I only have a user_id

sandhose · 2022-06-15T09:42:40Z

synapse/storage/databases/main/registration.py

    is_guest: bool = False
    shadow_banned: bool = False
-    token_id: Optional[int] = None


Because we're now only creating TokenLookupResults from the database, we know that this field will always be set

synapse/api/auth.py

Signed-off-by: Quentin Gliech <quenting@element.io>

instead of just the UserID Signed-off-by: Quentin Gliech <quenting@element.io>

…Requester Signed-off-by: Quentin Gliech <quenting@element.io>

…s and regular ones Signed-off-by: Quentin Gliech <quenting@element.io>

Signed-off-by: Quentin Gliech <quenting@element.io>

richvdh

@sandhose sorry for sitting on this for two months!

But... before I go through asking you to fix the docstrings 150 times... please can you fix the docstrings to match the new arguments?

Signed-off-by: Quentin Gliech <quenting@element.io>

sandhose · 2022-08-09T09:12:37Z

But... before I go through asking you to fix the docstrings 150 times... please can you fix the docstrings to match the new arguments?

Right, I missed that. Fixed!

richvdh

looks great in general! A few comments.

synapse/api/auth.py

richvdh · 2022-08-09T10:04:02Z

synapse/api/auth.py

+            mark_as_used: Mark the token as used, if it was used to
+                authenticate a regular C-S API request


isn't it more about the type of token than what it was used to authenticate (which this function doesn't know)?

Suggested change

mark_as_used: Mark the token as used, if it was used to

authenticate a regular C-S API request

mark_as_used: Mark the token as used, if it was a regular

C-S access token

I don't think so. This method is used in three places:

in Auth.get_user_by_req (this is where we want to mark the token as used)

in the module API, in the invalidate_access_token(token: str) method

when you upgrade a guest account to a regular one (for which the code path where this parameter matters is never taken, since it's a guest access token)

...which makes me think that I don't really know why I kept that parameter in the first place 🤔

Should I just get rid of this parameter? And maybe make the ModuleApi.invalidate_access_token method use the Store.get_user_by_access_token directly instead of the Auth one?

sure, getting rid of it seems sensible.

I got rid of the parameter in 1670733

richvdh · 2022-08-09T10:04:58Z

synapse/api/auth.py


    async def get_user_by_access_token(
        self,
        token: str,
        allow_expired: bool = False,
-    ) -> TokenLookupResult:
+        mark_as_used: bool = False,


yeah this is fine, though I wonder if the default should be True ?

richvdh · 2022-08-09T10:09:34Z

synapse/api/auth.py

-                        device_id="dummy-device"
-                        if device_id is None
-                        else device_id,  # stubbed
+                        device_id=requester.device_id,


this looks like a change in behaviour? we will now set device_id=None where previously it was "dummy-device". Is that deliberate?

It is, but probably not important: what it changes is that instead of inserting a 'dummy-device' in the client IP tracking for appservices requests it inserts NULL

instead of inserting a 'dummy-device' in the client IP tracking for appservices requests it inserts NULL

right, but can you convince me that's an ok change to make?

... and even if it is, do we really need to tie it into this refactoring PR?

I reverted that and added a comment about it in f74ff1f

synapse/handlers/auth.py

synapse/handlers/register.py

Signed-off-by: Quentin Gliech <quenting@element.io>

richvdh · 2022-08-15T18:26:37Z

@sandhose there are still a few oustanding comments here, so I think the ball is in your court?

Signed-off-by: Quentin Gliech <quenting@element.io>

sandhose · 2022-08-17T16:05:17Z

@richvdh Sorry about that, I don't know why I did not resolve those comments before re-requesting the review last week

It should be ready for another round now

richvdh

lgtm

synapse/api/auth.py

richvdh · 2022-08-18T14:52:29Z

synapse/api/auth.py

+                # XXX(quenting): I'm 95% confident that we could skip setting the
+                # device_id to "dummy-device" for appservices, and that the only impact
+                # would be that some rows which whould not deduplicate in the 'user_ips'
+                # table during the transition
+                recorded_device_id = (
+                    "dummy-device"
+                    if requester.device_id is None and requester.app_service is not None
+                    else requester.device_id
+                )


oh heh, I'd failed to grok we were previously only setting dummy-device if it was an appservice. Ah well, let's leave this for now.

Synapse 1.66.0rc1 (2022-08-23) ============================== This release removes the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. This removal was originally planned for Synapse 1.64, but was later deferred until now. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Features -------- - Improve validation of request bodies for the following client-server API endpoints: [`/account/password`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpassword), [`/account/password/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpasswordemailrequesttoken), [`/account/deactivate`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountdeactivate) and [`/account/3pid/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3account3pidemailrequesttoken). ([\#13188](#13188), [\#13563](#13563)) - Add forgotten status to [Room Details Admin API](https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#room-details-api). ([\#13503](#13503)) - Add an experimental implementation for [MSC3852 (Expose user agents on `Device`)](matrix-org/matrix-spec-proposals#3852). ([\#13549](#13549)) - Add `org.matrix.msc2716v4` experimental room version with updated content fields. Part of [MSC2716 (Importing history)](matrix-org/matrix-spec-proposals#2716). ([\#13551](#13551)) - Add support for compression to federation responses. ([\#13537](#13537)) - Improve performance of sending messages in rooms with thousands of local users. ([\#13522](#13522), [\#13547](#13547)) Bugfixes -------- - Faster room joins: make `/joined_members` block whilst the room is partial stated. ([\#13514](#13514)) - Fix a bug introduced in Synapse 1.21.0 where the [`/event_reports` Admin API](https://matrix-org.github.io/synapse/develop/admin_api/event_reports.html) could return a total count which was larger than the number of results you can actually query for. ([\#13525](#13525)) - Fix a bug introduced in Synapse 1.52.0 where sending server notices fails if `max_avatar_size` or `allowed_avatar_mimetypes` is set and not `system_mxid_avatar_url`. ([\#13566](#13566)) - Fix a bug where the `opentracing.force_tracing_for_users` config option would not apply to [`/sendToDevice`](https://spec.matrix.org/v1.3/client-server-api/#put_matrixclientv3sendtodeviceeventtypetxnid) and [`/keys/upload`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3keysupload) requests. ([\#13574](#13574)) Improved Documentation ---------------------- - Add `openssl` example for generating registration HMAC digest. ([\#13472](#13472)) - Tidy up Synapse's README. ([\#13491](#13491)) - Document that event purging related to the `redaction_retention_period` config option is executed only every 5 minutes. ([\#13492](#13492)) - Add a warning to retention documentation regarding the possibility of database corruption. ([\#13497](#13497)) - Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker image. ([\#13515](#13515)) - Add missing links in `user_consent` section of configuration manual. ([\#13536](#13536)) - Fix the doc and some warnings that were referring to the nonexistent `custom_templates_directory` setting (instead of `custom_template_directory`). ([\#13538](#13538)) Deprecations and Removals ------------------------- - Remove the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. See [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Internal Changes ---------------- - Update the rejected state of events during de-partial-stating. ([\#13459](#13459)) - Avoid blocking lazy-loading `/sync`s during partial joins due to remote memberships. Pull remote memberships from auth events instead of the room state. ([\#13477](#13477)) - Refuse to start when faster joins is enabled on a deployment with workers, since worker configurations are not currently supported. ([\#13531](#13531)) - Allow use of both `@trace` and `@tag_args` stacked on the same function. ([\#13453](#13453)) - Instrument the federation/backfill part of `/messages` for understandable traces in Jaeger. ([\#13489](#13489)) - Instrument `FederationStateIdsServlet` (`/state_ids`) for understandable traces in Jaeger. ([\#13499](#13499), [\#13554](#13554)) - Track HTTP response times over 10 seconds from `/messages` (`synapse_room_message_list_rest_servlet_response_time_seconds`). ([\#13533](#13533)) - Add metrics to track how the rate limiter is affecting requests (sleep/reject). ([\#13534](#13534), [\#13541](#13541)) - Add metrics to time how long it takes us to do backfill processing (`synapse_federation_backfill_processing_before_time_seconds`, `synapse_federation_backfill_processing_after_time_seconds`). ([\#13535](#13535), [\#13584](#13584)) - Add metrics to track rate limiter queue timing (`synapse_rate_limit_queue_wait_time_seconds`). ([\#13544](#13544)) - Update metrics to track `/messages` response time by room size. ([\#13545](#13545)) - Refactor methods in `synapse.api.auth.Auth` to use `Requester` objects everywhere instead of user IDs. ([\#13024](#13024)) - Clean-up tests for notifications. ([\#13471](#13471)) - Add some miscellaneous comments to document sync, especially around `compute_state_delta`. ([\#13474](#13474)) - Use literals in place of `HTTPStatus` constants in tests. ([\#13479](#13479), [\#13488](#13488)) - Add comments about how event push actions are rotated. ([\#13485](#13485)) - Modify HTML template content to better support mobile devices' screen sizes. ([\#13493](#13493)) - Add a linter script which will reject non-strict types in Pydantic models. ([\#13502](#13502)) - Reduce the number of tests using legacy TCP replication. ([\#13543](#13543)) - Allow specifying additional request fields when using the `HomeServerTestCase.login` helper method. ([\#13549](#13549)) - Make `HomeServerTestCase` load any configured homeserver modules automatically. ([\#13558](#13558))

Synapse 1.66.0 (2022-08-31) =========================== No significant changes since 1.66.0rc2. This release removes the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. This removal was originally planned for Synapse 1.64, but was later deferred until now. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Deployments with multiple workers should note that the direct TCP replication configuration was deprecated in Synapse v1.18.0 and will be removed in Synapse v1.67.0. In particular, the TCP `replication` [listener](https://matrix-org.github.io/synapse/v1.66/usage/configuration/config_documentation.html#listeners) type (not to be confused with the `replication` resource on the `http` listener type) and the `worker_replication_port` config option will be removed . To migrate to Redis, add the [`redis` config](https://matrix-org.github.io/synapse/v1.66/workers.html#shared-configuration), then remove the TCP `replication` listener from config of the master and `worker_replication_port` from worker config. Note that a HTTP listener with a `replication` resource is still required. See the [worker documentation](https://matrix-org.github.io/synapse/v1.66/workers.html) for more details. Synapse 1.66.0rc2 (2022-08-30) ============================== Bugfixes -------- - Fix a bug introduced in Synapse 1.66.0rc1 where the new rate limit metrics were misreported (`synapse_rate_limit_sleep_affected_hosts`, `synapse_rate_limit_reject_affected_hosts`). ([\matrix-org#13649](matrix-org#13649)) Synapse 1.66.0rc1 (2022-08-23) ============================== Features -------- - Improve validation of request bodies for the following client-server API endpoints: [`/account/password`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpassword), [`/account/password/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpasswordemailrequesttoken), [`/account/deactivate`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountdeactivate) and [`/account/3pid/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3account3pidemailrequesttoken). ([\matrix-org#13188](matrix-org#13188), [\matrix-org#13563](matrix-org#13563)) - Add forgotten status to [Room Details Admin API](https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#room-details-api). ([\matrix-org#13503](matrix-org#13503)) - Add an experimental implementation for [MSC3852 (Expose user agents on `Device`)](matrix-org/matrix-spec-proposals#3852). ([\matrix-org#13549](matrix-org#13549)) - Add `org.matrix.msc2716v4` experimental room version with updated content fields. Part of [MSC2716 (Importing history)](matrix-org/matrix-spec-proposals#2716). ([\matrix-org#13551](matrix-org#13551)) - Add support for compression to federation responses. ([\matrix-org#13537](matrix-org#13537)) - Improve performance of sending messages in rooms with thousands of local users. ([\matrix-org#13522](matrix-org#13522), [\matrix-org#13547](matrix-org#13547)) Bugfixes -------- - Faster room joins: make `/joined_members` block whilst the room is partial stated. ([\matrix-org#13514](matrix-org#13514)) - Fix a bug introduced in Synapse 1.21.0 where the [`/event_reports` Admin API](https://matrix-org.github.io/synapse/develop/admin_api/event_reports.html) could return a total count which was larger than the number of results you can actually query for. ([\matrix-org#13525](matrix-org#13525)) - Fix a bug introduced in Synapse 1.52.0 where sending server notices fails if `max_avatar_size` or `allowed_avatar_mimetypes` is set and not `system_mxid_avatar_url`. ([\matrix-org#13566](matrix-org#13566)) - Fix a bug where the `opentracing.force_tracing_for_users` config option would not apply to [`/sendToDevice`](https://spec.matrix.org/v1.3/client-server-api/#put_matrixclientv3sendtodeviceeventtypetxnid) and [`/keys/upload`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3keysupload) requests. ([\matrix-org#13574](matrix-org#13574)) Improved Documentation ---------------------- - Add `openssl` example for generating registration HMAC digest. ([\matrix-org#13472](matrix-org#13472)) - Tidy up Synapse's README. ([\matrix-org#13491](matrix-org#13491)) - Document that event purging related to the `redaction_retention_period` config option is executed only every 5 minutes. ([\matrix-org#13492](matrix-org#13492)) - Add a warning to retention documentation regarding the possibility of database corruption. ([\matrix-org#13497](matrix-org#13497)) - Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker image. ([\matrix-org#13515](matrix-org#13515)) - Add missing links in `user_consent` section of configuration manual. ([\matrix-org#13536](matrix-org#13536)) - Fix the doc and some warnings that were referring to the nonexistent `custom_templates_directory` setting (instead of `custom_template_directory`). ([\matrix-org#13538](matrix-org#13538)) Deprecations and Removals ------------------------- - Remove the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. See [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Internal Changes ---------------- - Update the rejected state of events during de-partial-stating. ([\matrix-org#13459](matrix-org#13459)) - Avoid blocking lazy-loading `/sync`s during partial joins due to remote memberships. Pull remote memberships from auth events instead of the room state. ([\matrix-org#13477](matrix-org#13477)) - Refuse to start when faster joins is enabled on a deployment with workers, since worker configurations are not currently supported. ([\matrix-org#13531](matrix-org#13531)) - Allow use of both `@trace` and `@tag_args` stacked on the same function. ([\matrix-org#13453](matrix-org#13453)) - Instrument the federation/backfill part of `/messages` for understandable traces in Jaeger. ([\matrix-org#13489](matrix-org#13489)) - Instrument `FederationStateIdsServlet` (`/state_ids`) for understandable traces in Jaeger. ([\matrix-org#13499](matrix-org#13499), [\matrix-org#13554](matrix-org#13554)) - Track HTTP response times over 10 seconds from `/messages` (`synapse_room_message_list_rest_servlet_response_time_seconds`). ([\matrix-org#13533](matrix-org#13533)) - Add metrics to track how the rate limiter is affecting requests (sleep/reject). ([\matrix-org#13534](matrix-org#13534), [\matrix-org#13541](matrix-org#13541)) - Add metrics to time how long it takes us to do backfill processing (`synapse_federation_backfill_processing_before_time_seconds`, `synapse_federation_backfill_processing_after_time_seconds`). ([\matrix-org#13535](matrix-org#13535), [\matrix-org#13584](matrix-org#13584)) - Add metrics to track rate limiter queue timing (`synapse_rate_limit_queue_wait_time_seconds`). ([\matrix-org#13544](matrix-org#13544)) - Update metrics to track `/messages` response time by room size. ([\matrix-org#13545](matrix-org#13545)) - Refactor methods in `synapse.api.auth.Auth` to use `Requester` objects everywhere instead of user IDs. ([\matrix-org#13024](matrix-org#13024)) - Clean-up tests for notifications. ([\matrix-org#13471](matrix-org#13471)) - Add some miscellaneous comments to document sync, especially around `compute_state_delta`. ([\matrix-org#13474](matrix-org#13474)) - Use literals in place of `HTTPStatus` constants in tests. ([\matrix-org#13479](matrix-org#13479), [\matrix-org#13488](matrix-org#13488)) - Add comments about how event push actions are rotated. ([\matrix-org#13485](matrix-org#13485)) - Modify HTML template content to better support mobile devices' screen sizes. ([\matrix-org#13493](matrix-org#13493)) - Add a linter script which will reject non-strict types in Pydantic models. ([\matrix-org#13502](matrix-org#13502)) - Reduce the number of tests using legacy TCP replication. ([\matrix-org#13543](matrix-org#13543)) - Allow specifying additional request fields when using the `HomeServerTestCase.login` helper method. ([\matrix-org#13549](matrix-org#13549)) - Make `HomeServerTestCase` load any configured homeserver modules automatically. ([\matrix-org#13558](matrix-org#13558)) # -----BEGIN PGP SIGNATURE----- # # iQGzBAABCgAdFiEEWMTnW8Z8khaaf90R+84KzgcyGG8FAmMPT8QACgkQ+84Kzgcy # GG9CUAv+Pv/iDpE2jKlV7zQ/cagaKCGsFK5jy0+K9Wr215nP89tuhU37bJXsgvVu # GP3A8k1c/ENPhXwYHLCnnxV3jick1FuVE0W6h0j2PMYeIGNCQhDswytnsQO4JExg # fGLL4ygCzpe8bFX9+mhIM4z8xkZjZX3lIa8CN2LtRLIo0m7qoT1ZWqdt7kAjj5yL # XMk+3Y1yq/Y4SHHqgKurBNdwNcwnv7ynchWxTYa12WVTINt26dLV0Syk3p8u2SLl # 5YNzcDs2TAM7+VxAu7E0AQl426+Ufi122Oj1ZBUG2FxTPLH8Xr18cN2M/at6WxoX # 8pOkGiuahKKvahw1iCoHAGIC66gFIPxBE9xW4R2SKrQtG4sDuKJI0kvunRV8+cy5 # TuJ9cmdDmJR2vj3P3OULqLXGkWsGNJqfZZF8OWkHEI8LUIXZLrAZocFtlonkr9rV # Y8r8LxL8Id1rbHAnCXcJnYdaJ6ol0RIObDFpitY/D8BDUONVw/byeOyAEkq/XPrZ # Ke/9K8sy # =eg1L # -----END PGP SIGNATURE----- # gpg: Signature made Wed Aug 31 13:10:44 2022 BST # gpg: using RSA key 58C4E75BC67C92169A7FDD11FBCE0ACE0732186F # gpg: Can't check signature: No public key # Conflicts: # synapse/api/auth.py # synapse/push/baserules.py # synapse/push/bulk_push_rule_evaluator.py # synapse/push/push_rule_evaluator.py # synapse/storage/databases/main/event_push_actions.py # tests/server_notices/test_resource_limits_server_notices.py

sandhose mentioned this pull request Jun 10, 2022

Clean up synapse.api.auth.Auth #13019

Closed

sandhose force-pushed the quenting/auth-api-cleanup/perm-requester branch 2 times, most recently from dcdfeb3 to 71ea338 Compare June 15, 2022 09:16

sandhose commented Jun 15, 2022

View reviewed changes

sandhose marked this pull request as ready for review June 15, 2022 09:48

sandhose requested a review from a team as a code owner June 15, 2022 09:48

erikjohnston reviewed Jun 15, 2022

View reviewed changes

synapse/api/auth.py Show resolved Hide resolved

sandhose force-pushed the quenting/auth-api-cleanup/perm-requester branch from c027f0e to 2a3238f Compare June 15, 2022 16:29

sandhose added 5 commits August 5, 2022 10:34

Pass the requester to assert_user_is_admin instead of the UserID

5358b88

Signed-off-by: Quentin Gliech <quenting@element.io>

Make the permissions-related methods use the requester

68474ee

instead of just the UserID Signed-off-by: Quentin Gliech <quenting@element.io>

Make Auth.get_user_by_access_token and _get_appservice_user return a …

6f2c0c3

…Requester Signed-off-by: Quentin Gliech <quenting@element.io>

Refactor get_user_by_req to keep the same logic for appservice user…

7beb0a4

…s and regular ones Signed-off-by: Quentin Gliech <quenting@element.io>

Newsfile.

c4bb34d

Signed-off-by: Quentin Gliech <quenting@element.io>

sandhose force-pushed the quenting/auth-api-cleanup/perm-requester branch from 2a3238f to c4bb34d Compare August 5, 2022 08:47

reivilibre requested a review from a team August 5, 2022 08:53

richvdh suggested changes Aug 8, 2022

View reviewed changes

Update the docstrings where the user_id param changed to the requester.

bcfa8d9

Signed-off-by: Quentin Gliech <quenting@element.io>

sandhose requested a review from richvdh August 9, 2022 09:12

richvdh reviewed Aug 9, 2022

View reviewed changes

Apply suggestions from code review

6e41a06

Signed-off-by: Quentin Gliech <quenting@element.io>

sandhose requested a review from richvdh August 9, 2022 13:18

richvdh removed their request for review August 15, 2022 18:26

sandhose added 5 commits August 17, 2022 17:25

Get rid of the mark_as_used parameter

1670733

Signed-off-by: Quentin Gliech <quenting@element.io>

Revert to using a dummy device ID for appservices user_ips recordings

f74ff1f

Signed-off-by: Quentin Gliech <quenting@element.io>

Fix tests mocks & use the right method in guest registration

9f91f78

Signed-off-by: Quentin Gliech <quenting@element.io>

Appease the linter

2a926c6

Signed-off-by: Quentin Gliech <quenting@element.io>

Merge branch 'develop' into quenting/auth-api-cleanup/perm-requester

f48a202

sandhose requested a review from richvdh August 17, 2022 16:05

richvdh approved these changes Aug 18, 2022

View reviewed changes

richvdh added 2 commits August 18, 2022 15:52

Update synapse/api/auth.py

7baca38

Merge branch 'develop' into quenting/auth-api-cleanup/perm-requester

1f3cceb

richvdh merged commit 3dd175b into matrix-org:develop Aug 22, 2022

sandhose deleted the quenting/auth-api-cleanup/perm-requester branch August 30, 2022 10:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`synapse.api.auth.Auth` cleanup: make permission-related methods use `Requester` instead of the `UserID` #13024

`synapse.api.auth.Auth` cleanup: make permission-related methods use `Requester` instead of the `UserID` #13024

sandhose commented Jun 10, 2022 •

edited

Loading

sandhose left a comment

sandhose Jun 15, 2022

richvdh Aug 9, 2022

sandhose Aug 9, 2022

sandhose Aug 17, 2022

sandhose Jun 15, 2022

sandhose Jun 15, 2022

richvdh left a comment

sandhose commented Aug 9, 2022

richvdh left a comment

richvdh Aug 9, 2022

sandhose Aug 9, 2022

richvdh Aug 9, 2022

sandhose Aug 17, 2022

richvdh Aug 9, 2022

richvdh Aug 9, 2022

sandhose Aug 9, 2022

richvdh Aug 9, 2022

richvdh Aug 9, 2022

sandhose Aug 17, 2022

richvdh commented Aug 15, 2022

sandhose commented Aug 17, 2022

richvdh left a comment

richvdh Aug 18, 2022

		mark_as_used: Mark the token as used, if it was used to
		authenticate a regular C-S API request

synapse.api.auth.Auth cleanup: make permission-related methods use Requester instead of the UserID #13024

synapse.api.auth.Auth cleanup: make permission-related methods use Requester instead of the UserID #13024

Conversation

sandhose commented Jun 10, 2022 • edited Loading

Pull Request Checklist

sandhose left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richvdh left a comment

Choose a reason for hiding this comment

sandhose commented Aug 9, 2022

richvdh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richvdh commented Aug 15, 2022

sandhose commented Aug 17, 2022

richvdh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

`synapse.api.auth.Auth` cleanup: make permission-related methods use `Requester` instead of the `UserID` #13024

`synapse.api.auth.Auth` cleanup: make permission-related methods use `Requester` instead of the `UserID` #13024

sandhose commented Jun 10, 2022 •

edited

Loading