Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Aggregate unread notif count query for badge count calculation #14255

Merged
merged 22 commits into from
Nov 30, 2022
Merged

Aggregate unread notif count query for badge count calculation #14255

merged 22 commits into from
Nov 30, 2022

Commits on Oct 21, 2022

  1. Add get_unread_counts_by_room_for_user method

    @Fizzadar
    Fizzadar committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    b227cd3 View commit details
    Browse the repository at this point in the history

  2. Test against new method

    @Fizzadar
    Fizzadar committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    9f9ac55 View commit details
    Browse the repository at this point in the history

  3. Use get_unread_counts_by_room_for_user when calculating badge counts

    @Fizzadar
    Fizzadar committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    0919941 View commit details
    Browse the repository at this point in the history

  4. Add changelog file

    @Fizzadar
    Fizzadar committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    9ce71cb View commit details
    Browse the repository at this point in the history

  5. Include return value in docstring 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @Fizzadar @clokep
    Fizzadar and clokep committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    0d9dda6 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Test aggregate notif counting with threads/mixed receipts

    @Fizzadar
    Fizzadar committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    bd7c694 View commit details
    Browse the repository at this point in the history

  2. Rewrite aggregate count query using CTE & two joins 

    This now correctly handles mixed threaded/unthreaded receipts.
    @Fizzadar
    Fizzadar committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    ffaba60 View commit details
    Browse the repository at this point in the history

  3. De-duplicate common SQL into variables 

    Makes the individual queries harder to read but also ensures they are
matching and better displays the similarities in queries required to do
notification counting.
    @Fizzadar
    Fizzadar committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    e343f6d View commit details
    Browse the repository at this point in the history

  4. Formatting

    @Fizzadar
    Fizzadar committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    3cfe596 View commit details
    Browse the repository at this point in the history

  5. Use GREATEST instead of a MAX when using postgres

    @Fizzadar
    Fizzadar committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    72e909e View commit details
    Browse the repository at this point in the history

  6. Fix group by clauses

    @Fizzadar
    Fizzadar committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    e79bc72 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2022

  1. Fix comment to match spec 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @Fizzadar @clokep
    Fizzadar and clokep committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    54dae60 View commit details
    Browse the repository at this point in the history

  2. Fix up docstring 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @Fizzadar @clokep
    Fizzadar and clokep committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    e0a1646 View commit details
    Browse the repository at this point in the history

  3. Fixup docstring 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @Fizzadar @clokep
    Fizzadar and clokep committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    330dd4b View commit details
    Browse the repository at this point in the history

  4. Tidy up comment 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @Fizzadar @clokep
    Fizzadar and clokep committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    c510d1c View commit details
    Browse the repository at this point in the history

  5. Fix query indents 

    Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
    @Fizzadar @clokep
    Fizzadar and clokep committed Nov 27, 2022
    Configuration menu
    Copy the full SHA
    0f8524c View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Fix tab/space indents

    @Fizzadar
    Fizzadar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    dc9e387 View commit details
    Browse the repository at this point in the history

  2. Add comment about room counts including stale counts

    @Fizzadar
    Fizzadar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    de2d9ba View commit details
    Browse the repository at this point in the history

  3. Move variable definition closer to usage

    @Fizzadar
    Fizzadar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    72c7be1 View commit details
    Browse the repository at this point in the history

  4. Fix typo in variable

    @Fizzadar
    Fizzadar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4068079 View commit details
    Browse the repository at this point in the history

  5. Only check aggregate counts for our target room

    @Fizzadar
    Fizzadar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ed3809f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into aggregate-unread-notif-count-query

    @Fizzadar
    Fizzadar committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    cf98d16 View commit details
    Browse the repository at this point in the history