Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Make sqlite database migrations transactional again, part two #14926

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Make sqlite database migrations transactional again, part two #14926

merged 2 commits into from
Jan 31, 2023

Commits on Jan 26, 2023

  1. Make sqlite database migrations transactional again, part two 

    #14910 fixed the regression introduced by #13873 where sqlite database
migrataions would no longer run inside a transaction. However, it
committed the transaction before Synapse updated its bookkeeping of
which migrations have been run, which means that migrations may be run
again after they have completed successfully.

Leave the transaction open at the end of `executescript`, to restore the
old, correct behaviour.

Fixes #14909.

Signed-off-by: Sean Quah <seanq@matrix.org>
    Sean Quah committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    6716f8c View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. fixup: make postgres behaviour consistent with sqlite

    Sean Quah committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    bb340f7 View commit details
    Browse the repository at this point in the history