Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix a bug introduced in Synapse v1.74.0 where searching with colons when using ICU for search term tokenisation would fail with an error. #15079

Merged
merged 9 commits into from Feb 20, 2023
Merged

Fix a bug introduced in Synapse v1.74.0 where searching with colons when using ICU for search term tokenisation would fail with an error. #15079

merged 9 commits into from Feb 20, 2023

Commits on Feb 15, 2023

  1. Add failing test

    @reivilibre
    reivilibre committed Feb 15, 2023
    Copy the full SHA
    0ce55f5 View commit details
    Browse the repository at this point in the history

  2. Small rename of variables

    @reivilibre
    reivilibre committed Feb 15, 2023
    Copy the full SHA
    b312e6d View commit details
    Browse the repository at this point in the history

  3. Add minitests to characterise how we do tokenisation today

    @reivilibre
    reivilibre committed Feb 15, 2023
    Copy the full SHA
    2085a40 View commit details
    Browse the repository at this point in the history

  4. Add escaping to our tsquery builder

    @reivilibre
    reivilibre committed Feb 15, 2023
    Copy the full SHA
    bc5c511 View commit details
    Browse the repository at this point in the history

  5. Test that we can find a user by prefix of MXID 

    (I wasn't super confident that the ICU tokeniser wouldn't break this, but a bit of poking later,

I think I'm happy. But thought it should be tested anyway!)
    @reivilibre
    reivilibre committed Feb 15, 2023
    Copy the full SHA
    a19355b View commit details
    Browse the repository at this point in the history

  6. Newsfile 

    Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
    @reivilibre
    reivilibre committed Feb 15, 2023
    Copy the full SHA
    30c722a View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Loosen test to accept at least 2 versions of ICU

    @reivilibre
    reivilibre committed Feb 16, 2023
    Copy the full SHA
    68d3c64 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Update tests/handlers/test_user_directory.py 

    Co-authored-by: David Robertson <davidr@element.io>
    @reivilibre
    reivilibre and David Robertson committed Feb 17, 2023
    Copy the full SHA
    e5c2c78 View commit details
    Browse the repository at this point in the history

  2. Let the tests run on both ICU and non-ICU

    @reivilibre
    reivilibre committed Feb 17, 2023
    Copy the full SHA
    ef37452 View commit details
    Browse the repository at this point in the history