This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Revert "Federation outbound proxy" #15910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #15773
Reverting because it opens up Synapse to be able to be used as an open proxy (security issue).
This happens because we apply the
ProxySitewhich handles thematrix-federation://proxying functionality to any Synapse instance.If you're running Synapse behind a reverse-proxy like nginx, it already blocks the type of request that allows this to happen. More details will come when we fix it.
The PR being reverted hasn't made it into any release yet.