Rename Rust evaluator event_property_contains field value_type to value too

[bnjbvr]

Following what happened in #15781.

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
  • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
• Pull request includes a sign off
• Code style is correct
  (run the linters)

[clokep]

Does this fix something or is it just refactoring?

[clokep]

This doesn't look right, the the code still searches for value_type at https://github.com/matrix-org/synapse/pull/15781/files#diff-50b62bc5724dfc17c692c9467f9a1f92af6ecb2b2afdc41cf96939e794d12f59R68

[bnjbvr]

I'm not familiar at all with this code, so I might be super wrong. Is this using an internal format that is live-converted to what the spec mandates? If so, then does the rust module use the internal format or the spec format?

[clokep]

Yes it is an internal format, the code I linked to is the serialization code which converts it.

[bnjbvr]

Does this fix something or is it just refactoring?

I thought I spotted an error in passing that could have been hard to figure, but sounds like I was wrong! Closing.

[clokep]

Does this fix something or is it just refactoring?

I thought I spotted an error in passing that could have been hard to figure, but sounds like I was wrong! Closing.

No worries! If you're seeing the foo_type over the Client-Server API definitely shout and we can look deeper into it.