Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Support releasing on macOS. #16266

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Support releasing on macOS. #16266

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5730854
Support releases on macOS.
clokep Sep 6, 2023
24a4933
Newsfragment
clokep Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
46 changes: 30 additions & 16 deletions scripts-dev/release.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,11 +244,17 @@ def _prepare() -> None:
else:
debian_version = new_version

run_until_successful(
f'dch -M -v {debian_version} "New Synapse release {new_version}."',
shell=True,
)
run_until_successful('dch -M -r -D stable ""', shell=True)
if sys.platform == "darwin":
run_until_successful(
f"docker run --rm -v .:/synapse ubuntu:latest /synapse/scripts-dev/docker_update_debian_changelog.sh {new_version}",
shell=True,
)
else:
run_until_successful(
f'dch -M -v {debian_version} "New Synapse release {new_version}."',
shell=True,
)
run_until_successful('dch -M -r -D stable ""', shell=True)

# Show the user the changes and ask if they want to edit the change log.
synapse_repo.git.add("-u")
Expand Down Expand Up @@ -566,19 +572,27 @@ def _notify(message: str) -> None:
# for this.
click.echo(f"\a{message}")

app_name = "Synapse Release Script"

# Try and run notify-send, but don't raise an Exception if this fails
# (This is best-effort)
Comment on lines 577 to 578
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lie -- I got an exception that the binary couldn't be found.

# TODO Support other platforms?
subprocess.run(
[
"notify-send",
"--app-name",
"Synapse Release Script",
"--expire-time",
"3600000",
message,
]
)
if sys.platform == "darwin":
# See https://developer.apple.com/library/archive/documentation/AppleScript/Conceptual/AppleScriptLangGuide/reference/ASLR_cmds.html#//apple_ref/doc/uid/TP40000983-CH216-SW224
subprocess.run(
f"""osascript -e 'display notification "{message}" with title "{app_name}"'""",
shell=True,
)
else:
subprocess.run(
[
"notify-send",
"--app-name",
app_name,
"--expire-time",
"3600000",
message,
]
)


@cli.command()
Expand Down