This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Update the stream_cache less often. #16586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/persist-single-room
branch
from
db97d2e
to
3157522
Compare
clokep
force-pushed
the
clokep/less-stream-cache
branch
from
6b98ace
to
8ba0c21
Compare
erikjohnston
reviewed
Nov 1, 2023
erikjohnston
approved these changes
Nov 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is safe to do -- instead of updating the stream cache (which is somewhat expensive) for each persisted event, only do it for the maximum stream ordering being persisted.
Based on #16584.