This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix assertion to stop transaction queue getting wedged #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and update some docstrings to correctly reflect the types being used. get_new_device_msgs_for_remote can return a long under some circumstances, which was being stored in last_device_list_stream_id_by_dest, and was then upsetting things on the next loop.
|
fixes #2003 |
|
LGTM. The casting is mostly to get from strings. We could/should probably change the int casts to longs, but whatevs |
|
isn't to get an int from a string. It seems to be to get an int from a long.
But, as you say, whatevs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and update some docstrings to correctly reflect the types being used.
I've done this as discussed, but having updated things to accurately reflect what's going on, am now having second thoughts and am wondering if it wouldn't have been better to cast the query result to
int- that seems to be what happens elsewhere in the codebase. WDYT?