This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
support custom login types for validating users #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
approved these changes
Dec 4, 2017
| provider.get_supported_login_types().keys() | ||
| ) | ||
| self._supported_login_types = frozenset(login_types) | ||
| for t in provider.get_supported_login_types().keys(): |
There was a problem hiding this comment.
Nit: prefer iterkeys(), but its probably fine here given the list is going to be small
Wire the custom login type support from password providers into the UI-auth user-validation flows.
richvdh
force-pushed
the
rav/custom_ui_auth
branch
from
37ba3b7
to
da1010c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wire the custom login type support from password providers into the UI-auth user-validation flows.
(includes #2728)