Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add trivial yaml config editor to synctl #278

Closed
wants to merge 2 commits into from
Closed

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Sep 10, 2015

This would make automated synapse installs like docker and unit tests a lot less painful. It keeps comments and formatting, although does change some minor things like the quoting style. Thoughts?

Review on Reviewable

…-trip yaml loader/dumper. Attempts to make life less painful with automated synapse setup, eg. Docker.
@erikjohnston
Copy link
Member

I would prefer if things like this weren't in synctl. I've recently added some stuff to synapse/config/main.py, so maybe that would be a better place for it?

How does this interact with multiple config files?

@dbkr
Copy link
Member Author

dbkr commented Sep 16, 2015

It will only edit homeserver.yaml, since synctl is hardcoded to only use this anyway. This seemed like an easy solution that kept it out of synapse core but if there is support in the core for something which makes automated editing/production of config files possible without sed/awk then I'm happy.

@dbkr dbkr closed this Jan 21, 2016
@dbkr dbkr deleted the cli-config-edit branch October 17, 2017 12:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants