Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Invalidate cache on correct thread #3473

Merged
merged 3 commits into from Jul 4, 2018
Merged

Conversation

erikjohnston
Copy link
Member

No description provided.

@erikjohnston erikjohnston requested a review from a team July 2, 2018 10:37
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, this looks important. Has this been causing problems in production?

Code lgtm but shouldn't the news file have some content?

@erikjohnston
Copy link
Member Author

It was causing some exceptions to be thrown, but that would simply cause the transaction to be retried. I don't know if it was causing any observable problems.

@erikjohnston erikjohnston assigned richvdh and unassigned erikjohnston Jul 2, 2018
@richvdh richvdh assigned erikjohnston and unassigned richvdh Jul 2, 2018
@erikjohnston erikjohnston merged commit 13f7adf into develop Jul 4, 2018
@erikjohnston erikjohnston deleted the erikj/thread_cache branch September 20, 2018 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants