This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Consider joined guest users as joined users #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, though it would be polite to say the conditions where you expect |
|
Added comments |
Otherwise they're inconveniently allowed to write events to the room but not to read them from the room.
illicitonion
force-pushed
the
daniel/guestscanjoin
branch
from
afd8da8
to
50f1afb
Compare
illicitonion
added a commit
that referenced
this pull request
Nov 12, 2015
Consider joined guest users as joined users Otherwise they're inconveniently allowed to write events to the room but not to read them from the room.
illicitonion
added a commit
that referenced
this pull request
Nov 12, 2015
Depends: #363 Tests in matrix-org/sytest#66
illicitonion
added a commit
that referenced
this pull request
Nov 12, 2015
Allow guests to set their display names Depends: #363 Tests in matrix-org/sytest#66
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise they're inconveniently allowed to write events to the room
but not to read them from the room.