This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Implementation of state rollback in /sync #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a couple of type annotations, docstrings, and other comments, in the interest of keeping track of what types I have.
Basically this moves the process of flattening the existing dictionary into a list up to rest.client.*, instead of doing it in handlers.sync. This simplifies a bit of the code in handlers.sync, but it is also going to be somewhat beneficial in the next stage of my hacking on SPEC-254.
Implementation of SPEC-254: roll back the state dictionary to how it looked at the start of the timeline.
richvdh
added a commit
to matrix-org/sytest
that referenced
this pull request
Nov 12, 2015
Sync now returns state corresponding to the *start* of the timeline. Update the tests to reflect that. This code tests the changes introduced in matrix-org/synapse#373.
|
LGTM |
richvdh
force-pushed
the
rav/return_state_dict
branch
from
405d26d
to
5ab4b0a
Compare
richvdh
added a commit
that referenced
this pull request
Nov 13, 2015
Implementation of SPEC-254: roll back the state dictionary to how it looked at the start of the timeline. Merged PR #373
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of SPEC-254: roll back the state dictionary to how it looked at
the start of the timeline.