This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix error handling for missing auth_event #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we were authorizing an event, if there was no `m.room.create` in its auth_events, we would raise a SynapseError with a cryptic message, which then meant that we would bail out of processing any incoming events, rather than storing a rejection for the faulty event and moving on. We should treat the absent event the same as any other auth failure, by raising an AuthError, so that the event is marked as rejected.
|
@richvdh do we have tests for this behaviour? |
richvdh
added this to To Do
in Superceded by https://github.com/orgs/matrix-org/projects/8
via automation
richvdh
moved this from To Do
to In Progress: Operational/bug fixes
in Superceded by https://github.com/orgs/matrix-org/projects/8
richvdh
added a commit
to matrix-org/sytest
that referenced
this pull request
Oct 1, 2018
richvdh
added a commit
to matrix-org/sytest
that referenced
this pull request
Oct 1, 2018
|
there is kind-of a test for this now in matrix-org/sytest#499. |
richvdh
added a commit
to matrix-org/sytest
that referenced
this pull request
Oct 1, 2018
richvdh
added a commit
to matrix-org/sytest
that referenced
this pull request
Oct 1, 2018
erikjohnston
approved these changes
Oct 2, 2018
richvdh
moved this from In Progress: Operational/bug fixes
to Done - Operations
in Superceded by https://github.com/orgs/matrix-org/projects/8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were authorizing an event, if there was no
m.room.createin itsauth_events, we would raise a SynapseError with a cryptic message, which
then meant that we would bail out of processing any incoming events, rather
than storing a rejection for the faulty event and moving on.
We should treat the absent event the same as any other auth failure, by
raising an AuthError, so that the event is marked as rejected.