This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
added this to To Do
in Superceded by https://github.com/orgs/matrix-org/projects/8
via automation
Nov 13, 2018
hawkowl
moved this from To Do
to Review
in Superceded by https://github.com/orgs/matrix-org/projects/8
Nov 13, 2018
richvdh
reviewed
Nov 15, 2018
tox.ini
Outdated
@@ -122,7 +133,7 @@ skip_install = True | |||
basepython = python3.6 | |||
deps = | |||
flake8 | |||
commands = /bin/sh -c "flake8 synapse tests scripts scripts-dev scripts/hash_password scripts/register_new_matrix_user scripts/synapse_port_db synctl {env:PEP8SUFFIX:}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this happening?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because i mismergedddddd
richvdh
suggested changes
Nov 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
(looks fine to me apart from the apparently unrelated removal of |
Superceded by https://github.com/orgs/matrix-org/projects/8
automation
moved this from Review
to Done - Operations
Nov 15, 2018
anoadragon453
pushed a commit
that referenced
this pull request
Feb 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.