New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jpeg to OpenBSD prereq list #4193

Merged
merged 2 commits into from Nov 17, 2018

Conversation

Projects
None yet
2 participants
@kivikakk
Copy link
Contributor

kivikakk commented Nov 16, 2018

Without the jpeg package installed, this occurs while installing the matrix-synapse Python package:

    The headers or library files could not be found for jpeg,
    a required dependency when compiling Pillow from source.

    Please see the install instructions at:
       https://pillow.readthedocs.io/en/latest/installation.html

    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-eSNi9N/pillow/setup.py", line 814, in <module>
        raise RequiredDependencyException(msg)
    __main__.RequiredDependencyException:

    The headers or library files could not be found for jpeg,
    a required dependency when compiling Pillow from source.

    Please see the install instructions at:
       https://pillow.readthedocs.io/en/latest/installation.html

@kivikakk kivikakk changed the base branch from master to develop Nov 16, 2018

@kivikakk

This comment has been minimized.

Copy link
Contributor

kivikakk commented Nov 16, 2018

Guess who didn't read the contributing guidelines first? 🤦‍♀️ Retargetted develop, added sign-off.

@kivikakk kivikakk force-pushed the kivikakk:add-openbsd-prereq branch from 5c2875a to 7787292 Nov 16, 2018

@hawkowl

This comment has been minimized.

Copy link
Contributor

hawkowl commented Nov 16, 2018

@kivikakk Hi! One other thing you need is a changelog entry -- CONTRIBUTING has more details, but you want to make a file called <PR number>.bugfix containing details, so people know it works now.

Thanks!

kivikakk added some commits Nov 16, 2018

add jpeg to OpenBSD prereq list
Signed-off-by: Ashe Connor <ashe@kivikakk.ee>

@kivikakk kivikakk force-pushed the kivikakk:add-openbsd-prereq branch from 7787292 to ceca3b2 Nov 17, 2018

@kivikakk

This comment has been minimized.

Copy link
Contributor

kivikakk commented Nov 17, 2018

@hawkowl Thanks for your patience! (And hello 😊) I've added the entry.

@hawkowl hawkowl merged commit 4285c81 into matrix-org:develop Nov 17, 2018

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment