New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a comment in the generated config #4387

Merged
merged 1 commit into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@richvdh
Copy link
Member

richvdh commented Jan 15, 2019

Changing macaroon_secret_key no longer logs you out (as of #4374)

@richvdh richvdh requested a review from matrix-org/synapse-core Jan 15, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #4387 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4387      +/-   ##
===========================================
- Coverage    73.67%   73.65%   -0.02%     
===========================================
  Files          300      300              
  Lines        29815    29815              
  Branches      4897     4897              
===========================================
- Hits         21965    21961       -4     
- Misses        6408     6412       +4     
  Partials      1442     1442
Impacted Files Coverage Δ
synapse/config/key.py 67.64% <ø> (ø) ⬆️
synapse/storage/background_updates.py 93% <0%> (-2.8%) ⬇️
synapse/handlers/user_directory.py 71.08% <0%> (-0.31%) ⬇️
synapse/util/file_consumer.py 82.45% <0%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e41545...ca87ce8. Read the comment docs.

@richvdh richvdh merged commit 3982a6e into develop Jan 16, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@richvdh richvdh deleted the rav/config_fix branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment