This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Check consent dir path on startup #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4512 +/- ##
============================================
+ Coverage 58.76% 74.75% +15.98%
============================================
Files 306 336 +30
Lines 32372 34222 +1850
Branches 5344 5571 +227
============================================
+ Hits 19024 25583 +6559
+ Misses 12027 7060 -4967
- Partials 1321 1579 +258 |
erikjohnston
approved these changes
Jan 29, 2019
|
I think it popped up now because it was introduced by https://github.com/matrix-org/synapse/pull/4384/files#diff-01aac508ef38061957e6fb961582e5ceL364, which moved the creation of the Handlers to the other side of the chdir. |
This was referenced Jan 29, 2019
|
Ah ok, that makes much more sense. That's for tracking the cause. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes consent directory absolute path issue introduced in #3213.
Fixes #4500
Fixes #4501
My question is why it only popped up now.