New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check consent dir path on startup #4512

Merged
merged 2 commits into from Jan 29, 2019

Conversation

Projects
None yet
4 participants
@anoadragon453
Copy link
Member

anoadragon453 commented Jan 29, 2019

Fixes consent directory absolute path issue introduced in #3213.

Fixes #4500
Fixes #4501

My question is why it only popped up now.

anoadragon453 added some commits Jan 29, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 29, 2019

Codecov Report

Merging #4512 into develop will increase coverage by 15.98%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##           develop    #4512       +/-   ##
============================================
+ Coverage    58.76%   74.75%   +15.98%     
============================================
  Files          306      336       +30     
  Lines        32372    34222     +1850     
  Branches      5344     5571      +227     
============================================
+ Hits         19024    25583     +6559     
+ Misses       12027     7060     -4967     
- Partials      1321     1579      +258

@anoadragon453 anoadragon453 requested a review from matrix-org/synapse-core Jan 29, 2019

@anoadragon453 anoadragon453 merged commit 03b0866 into develop Jan 29, 2019

5 checks passed

ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@anoadragon453 anoadragon453 deleted the anoa/consent_dir branch Jan 29, 2019

@richvdh

This comment has been minimized.

Copy link
Member

richvdh commented Jan 29, 2019

I think it popped up now because it was introduced by https://github.com/matrix-org/synapse/pull/4384/files#diff-01aac508ef38061957e6fb961582e5ceL364, which moved the creation of the Handlers to the other side of the chdir.

@anoadragon453

This comment has been minimized.

Copy link
Member Author

anoadragon453 commented Jan 29, 2019

Ah ok, that makes much more sense. That's for tracking the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment