Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the database pagination code #5007

Merged
merged 3 commits into from Apr 4, 2019

Conversation

2 participants
@hawkowl
Copy link
Contributor

commented Apr 4, 2019

No description provided.

hawkowl added some commits Apr 4, 2019

@hawkowl hawkowl added this to In progress in Homeserver Task Board via automation Apr 4, 2019

@hawkowl hawkowl requested a review from matrix-org/synapse-core Apr 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 4, 2019

Codecov Report

Merging #5007 into develop will increase coverage by <.01%.
The diff coverage is 15.38%.

@@             Coverage Diff             @@
##           develop    #5007      +/-   ##
===========================================
+ Coverage     60.7%   60.71%   +<.01%     
===========================================
  Files          332      332              
  Lines        34172    34170       -2     
  Branches      5633     5634       +1     
===========================================
  Hits         20745    20745              
+ Misses       11956    11954       -2     
  Partials      1471     1471
@richvdh

richvdh approved these changes Apr 4, 2019

Copy link
Member

left a comment

seems plausible. Suspect this is untested so who knows tbqh

@hawkowl hawkowl merged commit a33a5ab into develop Apr 4, 2019

24 checks passed

buildkite/synapse Build #840 passed (13 minutes, 43 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 11 seconds)
Details
buildkite/synapse/isort Passed (15 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (24 seconds)
Details
buildkite/synapse/packaging Passed (32 seconds)
Details
buildkite/synapse/pep-8 Passed (51 seconds)
Details
buildkite/synapse/pipeline Passed (3 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-4 Passed (11 minutes, 32 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-postgres-9-dot-5 Passed (11 minutes, 29 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite Passed (6 minutes, 33 seconds)
Details
buildkite/synapse/python-2-dot-7-slash-sqlite-slash-old-deps Passed (7 minutes, 56 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-4 Passed (12 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (12 minutes, 42 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (7 minutes, 20 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 18 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (12 minutes, 9 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (12 minutes, 3 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 20 seconds)
Details
ci/circleci: sytestpy2merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy2postgresmerged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3merged Your tests passed on CircleCI!
Details
ci/circleci: sytestpy3postgresmerged Your tests passed on CircleCI!
Details
codecov/patch 15.38% of diff hit (target 0%)
Details
codecov/project 60.71% (target 0%)
Details

Homeserver Task Board automation moved this from In progress to Done Apr 4, 2019

@hawkowl hawkowl deleted the hawkowl/paginate-cleanup branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.