Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Factor out KeyFetchers from KeyRing #5244

Merged
merged 3 commits into from
May 23, 2019
Merged

Factor out KeyFetchers from KeyRing #5244

merged 3 commits into from
May 23, 2019

Commits on May 23, 2019

  1. Store key validity time in the storage layer 

    This is a first step to checking that the key is valid at the required moment.

The idea here is that, rather than passing VerifyKey objects in and out of the
storage layer, we instead pass FetchKeyResult objects, which simply wrap the
VerifyKey and add a valid_until_ts field.
    @richvdh
    richvdh committed May 23, 2019
    Configuration menu
    Copy the full SHA
    b75537b View commit details
    Browse the repository at this point in the history

  2. Factor out KeyFetchers from KeyRing 

    Rather than have three methods which have to have the same interface,
factor out a separate interface which is provided by three implementations.

I find it easier to grok the code this way.
    @richvdh
    richvdh committed May 23, 2019
    Configuration menu
    Copy the full SHA
    895b79a View commit details
    Browse the repository at this point in the history

  3. Fix remote_key_resource

    @richvdh
    richvdh committed May 23, 2019
    Configuration menu
    Copy the full SHA
    ec24108 View commit details
    Browse the repository at this point in the history