Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Call RetryLimiter correctly #5340

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Call RetryLimiter correctly #5340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.d/5340.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix a bug where we could rapidly mark a server as unreachable even though it was only down for a few minutes.

7 changes: 6 additions & 1 deletion synapse/util/retryutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,12 @@ def get_retry_limiter(destination, clock, store, ignore_backoff=False, **kwargs)

defer.returnValue(
RetryDestinationLimiter(
destination, clock, store, retry_interval, backoff_on_failure, **kwargs
destination,
clock,
store,
retry_interval,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'd be tempted to make them all keyword arguments, but meh)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't have been a bad idea, indeed....

backoff_on_failure=backoff_on_failure,
**kwargs
)
)

Expand Down