This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use Postgres ANY for selecting many values. #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that we can write queries with `col = ANY(?)`, which helps postgres.
erikjohnston
force-pushed
the
erikj/postgres_any
branch
from
a59304e
to
203ccda
Compare
|
FTR I'm not 100% convinced that making the hand written queries more complicated is the right thing to do. |
richvdh
approved these changes
Oct 10, 2019
synapse/storage/_base.py
Outdated
| A tuple of SQL query and the args | ||
| """ | ||
|
|
||
| if isinstance(database_engine, PostgresEngine): |
There was a problem hiding this comment.
i'd be tempted to make this a method on the database engine, but ymmv
synapse/storage/_base.py
Outdated
| @@ -1693,3 +1695,49 @@ def db_to_json(db_content): | |||
| except Exception: | |||
| logging.warning("Tried to decode '%r' as JSON and failed", db_content) | |||
| raise | |||
|
|
|||
|
|
|||
| def add_in_list_sql_clause( | |||
There was a problem hiding this comment.
I'm not convinced that this function adds much in the way of clarity tbh. I'd be inclined to inline it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advantage of doing
col = ANY(?)rather thancol IN (?,?,?,...)is mainly to make looking at postgres query stats easier.