Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bunch of dead event_auth code. #6214

Merged
merged 5 commits into from Oct 18, 2019

Conversation

@richvdh
Copy link
Member

richvdh commented Oct 17, 2019

  1. The check_auth dev script didn't work, and I don't think it's been used in years. Let's kill it off.

  2. The only possible rejection reason is AUTH_ERROR, so there was a whole swathe of unrachable code starting in _update_auth_events_and_context_for_auth. Rip it out, along with the stuff in federation_client which was only used there.

richvdh added 3 commits Oct 11, 2019
This doesn't work, and afaict hasn't been used since 2015.
The only possible rejection reason is AUTH_ERROR, so all of this is unreachable.
@richvdh richvdh requested a review from matrix-org/synapse-core Oct 17, 2019
@richvdh richvdh added this to In progress in Homeserver Task Board via automation Oct 17, 2019
@richvdh richvdh moved this from In progress to Review in Homeserver Task Board Oct 17, 2019
@richvdh richvdh merged commit 47ada4d into develop Oct 18, 2019
18 checks passed
18 checks passed
buildkite/synapse Build #4982 passed (22 minutes, 37 seconds)
Details
buildkite/synapse/check-sample-config Passed (1 minute, 32 seconds)
Details
buildkite/synapse/check-style Passed (1 minute, 31 seconds)
Details
buildkite/synapse/isort Passed (17 seconds)
Details
buildkite/synapse/mypy Passed (24 seconds)
Details
buildkite/synapse/newspaper-newsfile Passed (46 seconds)
Details
buildkite/synapse/packaging Passed (20 seconds)
Details
buildkite/synapse/pipeline Passed (2 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-postgres-9-dot-5 Passed (19 minutes, 14 seconds)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite Passed (6 minutes, 1 second)
Details
buildkite/synapse/python-3-dot-5-slash-sqlite-slash-old-deps Passed (8 minutes, 35 seconds)
Details
buildkite/synapse/python-3-dot-6-slash-sqlite Passed (7 minutes, 13 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-11 Passed (18 minutes, 43 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-postgres-9-dot-5 Passed (16 minutes, 36 seconds)
Details
buildkite/synapse/python-3-dot-7-slash-sqlite Passed (7 minutes, 25 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-monolith Passed (15 minutes, 56 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-postgres-9-dot-6-slash-workers Passed (16 minutes, 59 seconds)
Details
buildkite/synapse/sytest-python-3-dot-5-slash-sqlite-slash-monolith Passed (16 minutes, 54 seconds)
Details
Homeserver Task Board automation moved this from Review to Done Oct 18, 2019
@richvdh richvdh deleted the rav/event_auth/1 branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.