Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Port much of synapse.handlers.federation to async/await. #6837

Merged
merged 27 commits into from
Feb 4, 2020
Merged

Port much of synapse.handlers.federation to async/await. #6837

merged 27 commits into from
Feb 4, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Feb 3, 2020

Sorry about the size of this.

Each commit converts a single method to async/await.

@richvdh
make FederationHandler.on_query_auth async
b3e44f0
@richvdh
make FederationHandler.on_send_join_request async
7571bf8
@richvdh
make FederationHandler.on_invite_request async
af8ba6b
@richvdh
make FederationHandler.on_make_join_request async
98681f9
@richvdh
make FederationHandler.on_send_leave_request async
d184cbc
@richvdh
make FederationHandler.on_make_leave_request async
6e89ec5
@richvdh
make FederationHandler._handle_new_events async
c556ed9
@richvdh
make FederationHandler._handle_new_event async
1cdc253
@richvdh
make FederationHandler._prep_event async
8033b25
@richvdh
make FederationHandler.do_auth async
bc9b75c
@richvdh
make FederationHandler._update_auth_events_and_context_for_auth async
a25ddf2
@richvdh
make FederationHandler._update_context_for_auth_events async
0d5f2f4
@richvdh
make FederationHandler.construct_auth_difference async
957129f
@richvdh
make FederationHandler.on_exchange_third_party_invite_request async
863087d
@richvdh
make FederationHandler.on_event_auth async
94f7b4c
@richvdh
make FederationHandler.do_invite_join async
ebd6a15
@richvdh
make FederationHandler._persist_auth_tree async
dbdf843
@richvdh
make FederationHandler._check_for_soft_fail async
c3f296a
@richvdh
make FederationHandler.do_remotely_reject_invite async
4286e42
@richvdh
make FederationHandler._make_and_verify_event async
3b7e0e0
@richvdh
make FederationHandler.persist_events_and_notify async
0529959
@richvdh
make FederationHandler._notify_persisted_event async
814cc00
@richvdh
make FederationHandler._clean_room_for_join async
5264286
@richvdh
make FederationHandler.user_joined_room async
f64c966
@richvdh
changelog
e49eb1a
@richvdh richvdh requested a review from a team February 3, 2020 18:02
@richvdh richvdh mentioned this pull request Feb 3, 2020
Merged
@anoadragon453 anoadragon453 self-assigned this Feb 4, 2020
anoadragon453
anoadragon453 reviewed Feb 4, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some @log_function decorators were removed though, do we not want to keep them?

@richvdh
Copy link
Member Author

richvdh commented Feb 4, 2020

Some @log_function decorators were removed though, do we not want to keep them?

my general feeling is not. I think they've been added indiscriminately and aren't terribly useful.

anoadragon453
anoadragon453 approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm then

@richvdh
Copy link
Member Author

richvdh commented Feb 4, 2020

thanks!

@richvdh richvdh merged commit c7d6d5c into develop Feb 4, 2020
@richvdh richvdh deleted the rav/federation_async branch February 4, 2020 12:06
@clokep clokep mentioned this pull request Jul 30, 2020
Closed
48 tasks
babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Merge pull request #6837 from matrix-org/rav/federation_async
f275c2c 
* commit 'c7d6d5c69': (27 commits)
  make FederationHandler.send_invite async
  make FederationHandler.on_get_missing_events async
  changelog
  make FederationHandler.user_joined_room async
  make FederationHandler._clean_room_for_join async
  make FederationHandler._notify_persisted_event async
  make FederationHandler.persist_events_and_notify async
  make FederationHandler._make_and_verify_event async
  make FederationHandler.do_remotely_reject_invite async
  make FederationHandler._check_for_soft_fail async
  make FederationHandler._persist_auth_tree async
  make FederationHandler.do_invite_join async
  make FederationHandler.on_event_auth async
  make FederationHandler.on_exchange_third_party_invite_request async
  make FederationHandler.construct_auth_difference async
  make FederationHandler._update_context_for_auth_events async
  make FederationHandler._update_auth_events_and_context_for_auth async
  make FederationHandler.do_auth async
  make FederationHandler._prep_event async
  make FederationHandler._handle_new_event async
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees

@anoadragon453 anoadragon453

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richvdh @anoadragon453