This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Database updates to populate rooms.room_version #6847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
approved these changes
Feb 4, 2020
synapse/storage/data_stores/main/schema/delta/57/rooms_version_column_2.sql.postgres
Outdated
Show resolved
Hide resolved
synapse/storage/data_stores/main/schema/delta/57/rooms_version_column_2.sql.sqlite
Outdated
Show resolved
Hide resolved
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
I think I managed to persuade @erikjohnston that it is what we want to do. |
|
yeaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaah |
|
what's the worst that can happen |
phil-flex
pushed a commit
to phil-flex/synapse
that referenced
this pull request
Apr 15, 2020
Fixes matrix-org#7065 This is basically the same as matrix-org#6847 except it tries to populate events from `state_events` rather than `current_state_events`, since the latter might have been cleared from the state of some rooms too early, leaving them with a `NULL` room version.
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'd88e0ec08': Database updates to populate rooms.room_version (#6847)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're going to need this so that we can figure out how to handle redactions when fetching events from the database.