Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Make complete_sso_login accessible from the module API #7007

Closed
wants to merge 2 commits into from
Closed

Make complete_sso_login accessible from the module API #7007

wants to merge 2 commits into from

Conversation

babolivier
Copy link
Contributor

To make matrix-org/matrix-synapse-saml-mozilla#4 possible and de-duplicate some code there.

@babolivier babolivier requested a review from a team February 27, 2020 23:13
@babolivier babolivier mentioned this pull request Feb 27, 2020
Merged
richvdh
richvdh suggested changes Feb 28, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this introduces an import cycle :/.

Also: please can you expose it as a new method, complete with docstrings (and type annotations), to document what exactly it does?

@babolivier babolivier changed the base branch from develop to release-v1.11.1 February 28, 2020 10:37
@anoadragon453
Copy link
Member

this introduces an import cycle :/.

Also: please can you expose it as a new method, complete with docstrings (and type annotations), to document what exactly it does?

What od you mean by it here?

@richvdh
Copy link
Member

richvdh commented Feb 28, 2020

What od you mean by it here?

complete_sso_login

@babolivier babolivier closed this Mar 2, 2020
@babolivier babolivier deleted the babolivier/sso_module_api branch October 28, 2021 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@richvdh richvdh richvdh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@babolivier @anoadragon453 @richvdh