Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix deprecation warning due to invalid escape sequences #7895

Merged
merged 2 commits into from Jul 20, 2020
Merged

Fix deprecation warning due to invalid escape sequences #7895

merged 2 commits into from Jul 20, 2020

Conversation

tirkarthi
Copy link
Contributor

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
  • Pull request includes a sign off
  • Code style is correct (run the linters)

Fixes #7894

@tirkarthi
Fix deprecation warnings due to invalid escape sequences.
c266403
@tirkarthi
Add changelog
2d022e8 
Signed-off-by: Karthikeyan Singaravelan <tir.karthi@gmail.com>
@clokep clokep requested a review from a team July 20, 2020 11:07
@clokep clokep changed the title Fix warnings Fix deprecation warning due to invalid escape sequences Jul 20, 2020
anoadragon453
anoadragon453 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this code seems to be broken anyways, as from synapse.federation import ReplicationHandler won't work anymore. And I'm not sure if we plan to keep it, but I'm happy to fix things up in case we decide to use this file again in the future.

Thanks for spotting!

@anoadragon453 anoadragon453 merged commit 4380207 into matrix-org:develop Jul 20, 2020
@anoadragon453 anoadragon453 mentioned this pull request Jul 20, 2020
Closed
@tirkarthi
Copy link
Contributor Author

Thanks @anoadragon453 :)

babolivier pushed a commit that referenced this pull request Sep 1, 2021
@anoadragon453
Merge commit 'de119063f' into anoa/dinsic_release_1_18_x
a567e76 
* commit 'de119063f': (31 commits)
  Convert room list handler to async/await. (#7912)
  Element CSS and logo in email templates (#7919)
  Lint the contrib/ directory in CI and linting scripts, add synctl to linting script (#7914)
  Remove unused code from synapse.logging.utils. (#7897)
  Fix a typo in the sample config. (#7890)
  Fix deprecation warning: import ABC from collections.abc (#7892)
  Change sample config's postgres user to synapse_user (#7889)
  Fix deprecation warning due to invalid escape sequences (#7895)
  Remove Ubuntu Eoan that is now EOL (#7888)
  Fix the trace function for async functions. (#7872)
  Add help for creating a user via docker (#7885)
  Switch to Debian:Slim from Alpine for the docker image (#7839)
  Stop using 'device_max_stream_id' (#7882)
  Fix TypeError in synapse.notifier (#7880)
  Add a default limit (of 100) to get/sync operations. (#7858)
  Change "unknown room ver" logging to warning. (#7881)
  Convert device handler to async/await (#7871)
  Convert synapse.app to async/await. (#7868)
  Convert _base, profile, and _receipts handlers to async/await (#7860)
  Add admin endpoint to get members in a room. (#7842)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anoadragon453 anoadragon453 anoadragon453 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning due to invalid escape sequences
2 participants
@tirkarthi @anoadragon453