Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add topic and avatar to room details admin API #8305

Merged
merged 3 commits into from Sep 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8305.feature
@@ -0,0 +1 @@
Add the room topic and avatar to the room details admin API.
4 changes: 4 additions & 0 deletions docs/admin_api/rooms.md
Expand Up @@ -275,6 +275,8 @@ The following fields are possible in the JSON response body:

* `room_id` - The ID of the room.
* `name` - The name of the room.
* `topic` - The topic of the room.
* `avatar` - The `mxc` URI to the avatar of the room.
* `canonical_alias` - The canonical (main) alias address of the room.
* `joined_members` - How many users are currently in the room.
* `joined_local_members` - How many local users are currently in the room.
Expand Down Expand Up @@ -304,6 +306,8 @@ Response:
{
"room_id": "!mscvqgqpHYjBGDxNym:matrix.org",
"name": "Music Theory",
"avatar": "mxc://matrix.org/AQDaVFlbkQoErdOgqWRgiGSV",
"topic": "Theory, Composition, Notation, Analysis",
"canonical_alias": "#musictheory:matrix.org",
"joined_members": 127
"joined_local_members": 2,
Expand Down
3 changes: 2 additions & 1 deletion synapse/storage/databases/main/room.py
Expand Up @@ -104,7 +104,8 @@ def get_room_with_stats_txn(txn, room_id):
curr.local_users_in_room AS joined_local_members, rooms.room_version AS version,
rooms.creator, state.encryption, state.is_federatable AS federatable,
rooms.is_public AS public, state.join_rules, state.guest_access,
state.history_visibility, curr.current_state_events AS state_events
state.history_visibility, curr.current_state_events AS state_events,
state.avatar, state.topic
FROM rooms
LEFT JOIN room_stats_state state USING (room_id)
LEFT JOIN room_stats_current curr USING (room_id)
Expand Down
2 changes: 2 additions & 0 deletions tests/rest/admin/test_room.py
Expand Up @@ -1174,6 +1174,8 @@ def test_single_room(self):

self.assertIn("room_id", channel.json_body)
self.assertIn("name", channel.json_body)
self.assertIn("topic", channel.json_body)
self.assertIn("avatar", channel.json_body)
self.assertIn("canonical_alias", channel.json_body)
self.assertIn("joined_members", channel.json_body)
self.assertIn("joined_local_members", channel.json_body)
Expand Down