This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Hotfix: disable autoescape by default when rendering Jinja2 templates #8394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templates from False to True. This caused some bugs, noticiably around redirect URLs being escaped in SAML2 auth confirmation templates, causing those URLs to break. This change returns the previous behaviour as it stood. We may want to look at each template individually and see whether autoescaping is a good idea at some point, but for now lets just fix the breakage.
anoadragon453
changed the base branch from
release-v1.20.0
to
release-v1.20.1
clokep
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Seems good, this essentially partially reverts #8037, specifically https://github.com/matrix-org/synapse/pull/8037/files#diff-70bd890cc0062e49a9de693507c8407aL179-L182
And note that autoescape is off by default although the documentation isn't super clear about this.
|
Merging even though |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8037 changed the default
autoescapeoption when rendering Jinja2 templates fromFalsetoTrue. This caused some bugs, noticeably around redirect URLs being escaped in SAML2 auth confirmation templates, causing those URLs to break for users.This change returns the previous behaviour as it stood. We may want to look at each template individually and see whether autoescaping is a good idea at some point, but for now lets just fix the breakage.