Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for removing redactions from search results #747

Merged
merged 7 commits into from
Dec 12, 2019

Conversation

anoadragon453
Copy link
Member

@anoadragon453 anoadragon453 commented Nov 19, 2019

Adds a test that sends two messages, redacts one of them, then searches for both. It should only get one, the non-redacted event, back.

Synapse PRs: matrix-org/synapse#6377, matrix-org/synapse#6522

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…ch_redacted_events

* 'develop' of github.com:matrix-org/sytest: (41 commits)
  Add comment to explain what the v1 outbound test relies on
  Re-fix test names
  Fix test names
  Incorporate review
  Add tests for outbout federation on v2 /send_join
  Fix on_request function name
  Version the name of the await functions (if the version isn't v1)
  Add handler for v2 /send_join
  Add support for versioning endpoints in await request pairs
  Add inbound test for v2 /send_join
  Diagnostics and increased timeout for a flaky LL test (#759)
  Test for preventing user logging in via email after account deactivation (#755)
  explain settngs
  Try to make the tests less flakey
  Use the same timings in both tests
  Name space room alias
  Style
  Fixup to actually pass.
  Use /sync instead of /messages to retrieve the first message
  Fix delay call
  ...
@anoadragon453
Copy link
Member Author

I've fixed the test to use scalar @$results instead of length @$results, as length apparently always returns 1, which was the value we were testing for.

@anoadragon453 anoadragon453 merged commit 0ba1c2d into develop Dec 12, 2019
@anoadragon453 anoadragon453 deleted the anoa/search_redacted_events branch December 12, 2019 17:30
anoadragon453 added a commit that referenced this pull request Mar 20, 2020
…ase-v1.8.x

* origin/release-v1.8.0: (27 commits)
  Test for outliers whose auth events are in a different room
  Test for receiving events with auth events in the wrong room
  enable frozen dicts in synapse (#778)
  Fix c&p error in #779
  Add support for synapse multi DB setups. (#775)
  Add console feedbak for the TAP output mode (#779)
  workaround for matrix-org/synapse#6536 (#772)
  Test for backfilled events whose prev_events cross room boundaries (#769)
  Add dendrite's logs to buildkite's artifacts (#773)
  Make the replication torture level adjustable (#771)
  Add test for removing redactions from search results (#747)
  Sanity-checking of some params (#765)
  Fix some 'undefined value' warnings (#768)
  Remove redundant fallback in on_request_federation_v1_event (#766)
  Deflake an AS test (#764)
  Add tests for outbound v2 invite API
  Fix diagnostics from logout test (#763)
  Add comment to explain what the v1 outbound test relies on
  Re-fix test names
  Fix test names
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants