Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not installing for go 1.15 #194

Closed
obaid-eltropy opened this issue Mar 28, 2023 · 3 comments · Fixed by #196
Closed

Not installing for go 1.15 #194

obaid-eltropy opened this issue Mar 28, 2023 · 3 comments · Fixed by #196

Comments

@obaid-eltropy
Copy link

As per the instructions given for installing moq for go < 1.16, I'm running the following command

go get github.com/matryer/moq

but I'm getting below errors

internal/registry/registry.go:55:68: undefined: types.TypeParamList
internal/registry/registry.go:65:15: undefined: types.TypeParamList
internal/registry/registry.go:68:18: named.TypeParams undefined (type *types.Named has no field or method TypeParams)

@breml
Copy link
Contributor

breml commented Mar 28, 2023

🤔 The go.mod file lists Go 1.18 as requirement. Also the CI pipelines are only testing with Go >= 1.18. So I am not sure, if support for Go < 1.18 is still a goal. Maybe just the instructions in the README.md are outdated.

@obaid-eltropy
Copy link
Author

Since the installation instruction said as follows

To start using latest released version of Moq, just run:

Go version < 1.16
$ go get github.com/matryer/moq

So just wanted to check if it is still supported

@sudo-suhas
Copy link
Collaborator

Support for building moq on older versions of Go was discontinued with #175. I called this out in the v0.3.0 release but missed updating the docs. Will close this issue after updating docs.

Even on older versions of Go, you can grab and use the pre-build binaries from the releases section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants