Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BitBarDarkMode ENV is always true #734

Open
nickdos opened this issue Jun 25, 2021 · 3 comments
Open

BitBarDarkMode ENV is always true #734

nickdos opened this issue Jun 25, 2021 · 3 comments
Labels

Comments

@nickdos
Copy link

nickdos commented Jun 25, 2021

Using Mac OS 11.4 and running Xbar 2.0.42-beta and I'm using a plugin (github-review-requests.5m.py) that sets text colour based on $BitBarDarkMode:

DARK_MODE = os.environ.get('BitBarDarkMode')

Changing OS dark mode on and off makes no difference to the value of this var - it always evaluates to true and thus text appears white and is unreadable when dark mode is off.

Seems related to #470.

@matryer matryer added the bug label Jul 14, 2021
@npearson72
Copy link

I'm seeing this issue too. I'm on MacOS Monterey 12.4 (21F79)

@onaforeignshore
Copy link

While the variable is now XBARDarkMode, it is still always true. Will this be fixed as it's been open for nearly 2 years at this point?

@leaanthony
Copy link
Collaborator

Thanks for bumping this. There's stuff happening in the background regarding the project so expect some movements in the near future. Let us know if you'd be willing to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants