Skip to content
This repository has been archived by the owner on Nov 30, 2020. It is now read-only.

Fix(snackbar): labelText is empty when using default slot as the labal text #240

Merged
merged 3 commits into from
May 16, 2019

Conversation

tychenjiajun
Copy link
Contributor

https://codepen.io/chankcccc/pen/EzWwGN

Although users can choose either the labelText prop or default slot to place the label text. It's recommended to use only one of this at a time.

Copy link
Owner

@matsp matsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tychenjiajun tychenjiajun merged commit f0ddd6c into matsp:master May 16, 2019
@tychenjiajun tychenjiajun deleted the snackbar branch May 16, 2019 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants