feat: #12 : prepare the MANIFEST for packaging as osgi fragment #13
Conversation
| Manifest-Version: 1.0 | ||
| Bundle-ManifestVersion: 2 | ||
| Bundle-Name: Liquibase Slf4j Logging | ||
| Bundle-SymbolicName: com.mattbertolini.liquibase.logging.slf4j | ||
| Bundle-Version: 4.0.0 | ||
| Automatic-Module-Name: com.mattbertolini.liquibase.logging.slf4j | ||
| Bundle-RequiredExecutionEnvironment: JavaSE-11 | ||
| Export-Package: com.mattbertolini.liquibase.logging.slf4j;version="4.0.0" | ||
| Import-Package: liquibase.logging;version="4.0.0", | ||
| liquibase.logging.core;version="4.0.0", | ||
| org.junit.jupiter.api;version="5.7.1";resolution:=optional, | ||
| org.mockito;version="2.23.0";resolution:=optional, | ||
| org.mockito.stubbing;version="2.23.0";resolution:=optional, | ||
| org.slf4j;version="1.7.0" | ||
| Fragment-Host: org.liquibase.core;bundle-version="[4.0.0,5.0.0)" |
There was a problem hiding this comment.
Question: I don't understand why the file was moved from src/main/resources? Also, is there a way to generate these values? I don't want to be in the business of figuring out these imports. The liquibase version supported is version 4.1, not 4.0. Finally, the library supports Java 8 so that execution environment would have to be changed.
There was a problem hiding this comment.
This is to make it easier to import/maintain it in Eclipse IDE.
I could go for other approaches indeed, based on the BND tool, to generate the manifest.
But I don't know if/how they support Ant&Ivy builds, afaik they have maven integration only.
|
|
||
| <target name="-process-meta-inf-resources" if="meta_inf.dir.exists"> | ||
| <macro:processresources dir="${meta_inf.dir}" todir="${build.main.dir}/META-INF"/> | ||
| </target> |
There was a problem hiding this comment.
I don't think this, or any of the ant changes are needed if the manifest file is just kept where it is.
| @@ -20,6 +20,7 @@ | |||
| import liquibase.logging.LogMessageFilter; | |||
| import org.junit.jupiter.api.BeforeEach; | |||
| import org.junit.jupiter.api.Test; | |||
| import org.mockito.stubbing.OngoingStubbing; | |||
There was a problem hiding this comment.
Is this import needed. I don't see any other changes.
|
Hi. Thanks for the PR. I'm a bit hesitant about adding this as I am not too familar with OSGi. I see the build is failing so that will need to be addressed. |
|
Hmm, apparently emptying the resources folder effectively made it disappear in the repo, which was not the case on my local system. I'll adapt things. |
|
Closing as the OSGi metadata was generated via BND in #14. |
No description provided.