Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding emojis directly inside a '-enclosed string #9

Open
voxpelli opened this issue Jun 14, 2018 · 2 comments
Open

Support adding emojis directly inside a '-enclosed string #9

voxpelli opened this issue Jun 14, 2018 · 2 comments

Comments

@voxpelli
Copy link

I want this to result in an emoji-suggestion:

console.log(':wa');

Currently only this does:

console.log(' :wa');

Removing the need for an initial space would be 👌

I often add Emojis at the beginning of a string, especially in logs, as it makes it easier to find that line among all of the lines of a project. Before I've used the Atom equivalent of this module.

@mattbierner
Copy link
Owner

Yeah this on is explicitly disabled right now because it can cause a lot of false positives, such as triggering emoji intellisense when you type : in {'a': b }. Two possible solutions that don't require understanding the language:

  • Show intellisense in this case if you manually request it (hitting ctrl+space)
  • Make restriction on the previous character less restrictive. It could instead match a : preceded by any non-alphanumeric character perhaps. Still would be broken for {'a': b }

The first seems like the better solution

@voxpelli
Copy link
Author

First one seems simple, but wouldn't it be possible to know if it's a string or not from each language grammar/parser? An always allow this syntax within string contexts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants