Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incorrect syntax in an idf file more gracefully #18

Closed
mattdoiron opened this issue Mar 1, 2020 · 7 comments
Closed

Handle incorrect syntax in an idf file more gracefully #18

mattdoiron opened this issue Mar 1, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@mattdoiron
Copy link
Owner

The program will currently crash if the idf file isn't perfect. Instead, there should be a friendly error window describing what the problem is.

@mattdoiron mattdoiron added the enhancement New feature or request label Mar 1, 2020
@mattdoiron mattdoiron self-assigned this Mar 1, 2020
@mattdoiron
Copy link
Owner Author

This partially addresses #26. A dialog will now warn if the name of an idf object is not valid (according to the idd file).

→ <<cset c7511115caad>>

@mattdoiron
Copy link
Owner Author

Should be more forgiving with capitalization. Should convert case before check if an object name is valid, but always write files using exactly the capitalization found in the IDD file.

@mattdoiron
Copy link
Owner Author

Issue #34 was marked as a duplicate of this issue.

@mattdoiron
Copy link
Owner Author

As seen in Issue #34 the types of objects present is also important. There should be a validation that takes place when the file is loaded and then report to the user on the "quality" of the idf file, or just load it as best we can.

@mattdoiron
Copy link
Owner Author

Noticed that even the IDD file has some errors like commas in /field tags. This messes up the parsing of these objects.

@mattdoiron
Copy link
Owner Author

It would be relatively easy to always convert object classes to lower case and do all comparisons with the converted version, however, in the sidebar (class view) it is easier to read things capitalized as expected (i.e. Site:GroundReflectance instead of site:groundreflectance). So, do properly fix this issue I need to save both versions - one for use as in index for comparison and the other for a nice visual representation.

@mattdoiron
Copy link
Owner Author

Closing as resolved unless I can find specific cases where it still is the case. Issue #44 was that last outstanding one that I know of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant