Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voltage control doesn't convert uV to mV for proper display of voltage limit #1

Closed
Unspec7 opened this issue Feb 28, 2019 · 2 comments

Comments

@Unspec7
Copy link

Unspec7 commented Feb 28, 2019

Steps to reproduce:

  1. Open AccA
  2. Edit Config
  3. Edit voltage limit
  4. Enable voltage limit
  5. Enter valid limit (e.g 4100)
  6. Click Ok, save config
  7. Go back into config editor and edit voltage limit
  8. Voltage limit is now displayed in microVolts (4100 -> 4100000)

Acc reports voltage limits in microVolts, not milliVolts even though the voltage limit is set via milliVolts, which is probably why the voltage limit is displaying incorrectly

@MatteCarra
Copy link
Owner

Thanks for the report.
My phone does not support voltage control so I was not able to test it.
VR25 is working on making every voltage expressed in mV so this problem will be fixed in the next acc release, but I might fix it for the app before

MatteCarra added a commit that referenced this issue Feb 28, 2019
@MatteCarra
Copy link
Owner

Let me know if it works for you.
The apk is zipped:
app-release.zip

MatteCarra pushed a commit that referenced this issue Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants