Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useRefs Hook #18

Open
rimuy opened this issue Feb 11, 2024 · 2 comments
Open

useRefs Hook #18

rimuy opened this issue Feb 11, 2024 · 2 comments
Labels
feature New feature or request

Comments

@rimuy
Copy link
Contributor

rimuy commented Feb 11, 2024

Linked to #17
@rimuy rimuy added the feature New feature or request label Feb 11, 2024
@rimuy
Copy link
Contributor Author

rimuy commented Feb 12, 2024 •
edited
Loading

Also accomplishes what seems it should've been possible from the beginning: https://github.com/evaera/plasma/blob/615632409813feb2d74f4d88f1f99ee01c8786bb/src/create.lua#L41-L54

@rimuy
Copy link
Contributor Author

rimuy commented Feb 12, 2024

There's not really an alternative here, it's either this or giving the user a way to set the current node.refs via some function, the behavior of erroring outside useInstance should still stay. It still makes more sense just returning the table so users could do that manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rimuy