Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

Integration of optimized keccak precompile #41

Open
wants to merge 46 commits into
base: dev
Choose a base branch
from
Open

Integration of optimized keccak precompile #41

wants to merge 46 commits into from

Conversation

StanislavBreadless
Copy link
Collaborator

@StanislavBreadless StanislavBreadless commented Oct 12, 2023 •
edited

What ❔

Integration of the optimized Keccak256 precompile together with the migration to it.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@StanislavBreadless StanislavBreadless mentioned this pull request Oct 13, 2023
Closed
4 tasks
vladbochok
vladbochok approved these changes Oct 13, 2023
View reviewed changes
bootloader/bootloader.yul Outdated Show resolved Hide resolved
@StanislavBreadless StanislavBreadless marked this pull request as ready for review October 13, 2023 15:31
@StanislavBreadless StanislavBreadless changed the title Draft: Integration of optimized keccak precompile Integration of optimized keccak precompile Oct 14, 2023
@AntonD3
Copy link
Contributor

AntonD3 commented Oct 18, 2023

Btw, right now in order to preprocess the bootloader you need to build the Keccak256, it depends on the bytecode hash. And the compile-yul script compiles all the yul contracts(including the bootloader), so that's not possible to do it without errors. But that's not really important, because it's possible to run the compile-yul two times and just ignore the error.

AntonD3 and others added 5 commits October 20, 2023 16:00
@AntonD3 @StanislavBreadless @vladbochok
Zero ptr keccak test (#44)
d89a918 
* Zero ptr keccak test

* Update contracts/test-contracts/KeccakTest.sol

Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>

---------

Co-authored-by: Stanislav Bezkorovainyi <stanislavbezkor@gmail.com>
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
@StanislavBreadless
add unit test for upgrade keccak
db2c0d8
@StanislavBreadless
remove redundant test contract
9bec033
@StanislavBreadless
use latest vm version
13664fc
@StanislavBreadless
readme for testing
217e115
vladbochok
vladbochok reviewed Oct 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
vladbochok
vladbochok approved these changes Oct 23, 2023
View reviewed changes
contracts/precompiles/Keccak256.yul Outdated Show resolved Hide resolved
contracts/precompiles/Keccak256.yul Show resolved Hide resolved
contracts/precompiles/Keccak256.yul Outdated Show resolved Hide resolved
bootloader/bootloader.yul Outdated Show resolved Hide resolved
scripts/quick-setup.sh Outdated Show resolved Hide resolved
koloz193 and others added 23 commits November 15, 2023 17:26
@koloz193
mined a few blocks to trigger keccak upgrade
5234858
@koloz193
added in additional check to make sure the mock keccak was in use
d695779
@StanislavBreadless
remove unneeded tests + make compilation work out of the box
a4dc0d9
@StanislavBreadless
fix build scripts
54c4a77
@StanislavBreadless
Merge pull request #63 from matter-labs/vb-fix-oz-keccak256-audit-n-04
bc495d0 
Fix incorrect calculation for required number of keccak256 hash rounds
@StanislavBreadless
Merge pull request #62 from matter-labs/vb-fix-oz-keccak256-audit-n-03
7b26445 
Reorder getter functions in the Bootloader
@StanislavBreadless
Merge pull request #58 from matter-labs/sb-enhance-keccak-tests
123bb68 
Better tests for keccak precompile
@StanislavBreadless
Merge pull request #61 from matter-labs/vb-fix-oz-keccak256-audit-n-02
d2001f6 
Add comments for keccak256 wrapper
@StanislavBreadless
Merge pull request #60 from matter-labs/vb-fix-oz-keccak256-audit-n-01
6903d17 
Add missing Comments for temporary functions in Bootloader and ContractDeployer
@StanislavBreadless
Merge pull request #57 from matter-labs/sb-add-constructor-code
b560437 
Add constructor code
@StanislavBreadless @vladbochok
Update README.md
4c5a6cd 
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
@StanislavBreadless @vladbochok
Update contracts/precompiles/Keccak256.yul
9703ff5 
Co-authored-by: Vlad Bochok <41153528+vladbochok@users.noreply.github.com>
@StanislavBreadless
resolve nits
66cfc62
@StanislavBreadless
Merge remote-tracking branch 'origin/v1-4-1-integration' into v1-4-1-…
cb89135 
…integration
@StanislavBreadless
sync with latest dev
1a674e1
@StanislavBreadless
fmt
8d0915d
@StanislavBreadless
remove outdated comment
2e036be
@StanislavBreadless
recalculate hashes
b1728f3
@StanislavBreadless
fix lint
fdaf998
@StanislavBreadless
upd hashes
820cc14
@StanislavBreadless
Merge pull request #78 from matter-labs/sb-remove-outdated-comment
ef0eb0c 
Remove outdated comment
@StanislavBreadless
Fix typographical errors (#91)
8979a4f 
fix typos
@StanislavBreadless
Fix misleading comment (#92)
51f5f0a 
* fix misleading comment

* fix lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vladbochok vladbochok vladbochok approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StanislavBreadless @AntonD3 @vladbochok @koloz193