Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(en): Fix miscellaneous snapshot recovery nits #1701

Merged
merged 13 commits into from Apr 18, 2024
Merged

fix(en): Fix miscellaneous snapshot recovery nits #1701

merged 13 commits into from Apr 18, 2024

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Apr 16, 2024 •
edited

What ❔

  • Allows to configure concurrency during DB recovery and restricts it to 10 by default.
  • Sets the "affected" health status while the recovery is in progress.

Why ❔

  • DB recovery is very I/O-heavy, so having concurrency less than the DB pool size can utilize node resources more efficiently.
  • "Affected" health status is more idiomatic; the node with such a status still passes readiness checks, but it signals that it isn't fully functional.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

slowli
slowli commented Apr 17, 2024
View reviewed changes
Cargo.toml Show resolved Hide resolved
@slowli slowli marked this pull request as ready for review April 17, 2024 09:41
@slowli
Copy link
Contributor Author

slowli commented Apr 18, 2024

JFYI, this PR now has substantial intersection with #1532 in terms of metadata calculator. I'd prefer for this PR to be merged first.

@slowli slowli requested a review from perekopskiy April 18, 2024 08:36
@slowli slowli added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit 13bfecc Apr 18, 2024
40 of 41 checks passed
@slowli slowli deleted the aov-pla-883-fix-misc-snapshot-recovery-nits branch April 18, 2024 10:48
This was referenced Apr 18, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 22, 2024
@zksync-era-bot @perekopskiy
chore(main): release prover 13.0.0 (#1534)
933cad2 
🤖 I have created a release *beep* *boop*
---


##
[13.0.0](prover-v12.2.0...prover-v13.0.0)
(2024-04-22)


### ⚠ BREAKING CHANGES

* **vm:** 1 5 0 support
([#1508](#1508))

### Features

* Archive old prover jobs
([#1516](#1516))
([201476c](201476c))
* Archiving of prover in gpu_prover_queue
([#1537](#1537))
([a970629](a970629))
* **configs:** Implement new format of configs and implement protobuf
for it ([#1501](#1501))
([086ba5b](086ba5b))
* **db:** Wrap sqlx errors in DAL
([#1522](#1522))
([6e9ed8c](6e9ed8c))
* fix availability checker
([#1574](#1574))
([b2f21fb](b2f21fb))
* Prover CLI Scaffoldings
([#1609](#1609))
([9a22fa0](9a22fa0))
* Remove zksync-rs SDK
([#1559](#1559))
([cc78e1d](cc78e1d))
* **sqlx:** Use offline mode by default
([#1539](#1539))
([af01edd](af01edd))
* **vm:** 1 5 0 support
([#1508](#1508))
([a6ccd25](a6ccd25))


### Bug Fixes

* **en:** Fix miscellaneous snapshot recovery nits
([#1701](#1701))
([13bfecc](13bfecc))
* made consensus store certificates asynchronously from statekeeper
([#1711](#1711))
([d1032ab](d1032ab))


### Performance Improvements

* **merkle tree:** Manage indices / filters in RocksDB
([#1550](#1550))
([6bbfa06](6bbfa06))


### Reverts

* **env:** Remove `ZKSYNC_HOME` env var from server
([#1713](#1713))
([aed23e1](aed23e1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
RomanBrodetski pushed a commit that referenced this pull request Apr 22, 2024
@zksync-era-bot @perekopskiy
chore(main): release core 23.1.0 (#1709)
d95a1fd 
🤖 I have created a release *beep* *boop*
---


##
[23.1.0](core-v23.0.0...core-v23.1.0)
(2024-04-22)


### Features

* **en:** Add boxed L2 client and use it in DI
([#1627](#1627))
([9948187](9948187))
* Extract block_reverter into separate crate
([#1632](#1632))
([8ab2488](8ab2488))
* Extract house keeper into separate crate
([#1685](#1685))
([f6f49b7](f6f49b7))
* remove enum index migration
([#1734](#1734))
([13c0f52](13c0f52))
* **state-keeper:** miniblock max payload size (BFT-417)
([#1284](#1284))
([a3c8e81](a3c8e81))


### Bug Fixes

* **en:** Fix miscellaneous snapshot recovery nits
([#1701](#1701))
([13bfecc](13bfecc))
* ensure two connections for both executor and async catchup
([#1755](#1755))
([3b14a9f](3b14a9f))
* made consensus store certificates asynchronously from statekeeper
([#1711](#1711))
([d1032ab](d1032ab))
* **merkle_tree:** don't panic in `BlockOutputWithProofs::verify_proofs`
([#1717](#1717))
([a44fac9](a44fac9))
* **types:** fix LegacyCall type
([#1739](#1739))
([712919f](712919f))


### Performance Improvements

* **en:** Monitor recovery latency by stage
([#1725](#1725))
([d7efdd5](d7efdd5))


### Reverts

* **env:** Remove `ZKSYNC_HOME` env var from server
([#1713](#1713))
([aed23e1](aed23e1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: perekopskiy <mikeson.dp@gmail.com>
Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
@slowli slowli mentioned this pull request Apr 23, 2024
Merged
1 task
github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2024
@slowli
fix(en): Revert using liburing for EN Docker image (#1767)
1c02ec6 
## What ❔

Removes `liburing` dependency in the EN image introduced in #1701.

## Why ❔

`liburing` doesn't lead to much performance improvement in practice, and
it complicates using the EN executable outside Docker.

## Checklist

- [x] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanBrodetski RomanBrodetski RomanBrodetski approved these changes

@perekopskiy perekopskiy Awaiting requested review from perekopskiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@slowli @RomanBrodetski