Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extract block_reverter into separate crate #1632

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

AnastasiiaVashchuk
Copy link
Contributor

@AnastasiiaVashchuk AnastasiiaVashchuk commented Apr 10, 2024

What ❔

Extract zksync_core::block_reverter to separate the crate in the node folder

Why ❔

Part of the to "modularize the codebase" process, required for legolizer and publishing on crates.io.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@AnastasiiaVashchuk AnastasiiaVashchuk marked this pull request as ready for review April 10, 2024 12:28
montekki
montekki previously approved these changes Apr 10, 2024
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder how the reverter will fit into the node framework (it doesn't look like a component), but if it does, I'm all for it.

Cargo.toml Show resolved Hide resolved
@AnastasiiaVashchuk
Copy link
Contributor Author

Wonder how the reverter will fit into the node framework (it doesn't look like a component), but if it does, I'm all for it.

yeah,.. it's more like a tool..but it lives in zksync_core rn + Igor mentioned it when we discussed modules' extraction with him.

slowli
slowli previously approved these changes Apr 12, 2024
@AnastasiiaVashchuk AnastasiiaVashchuk added this pull request to the merge queue Apr 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 12, 2024
@slowli slowli enabled auto-merge April 17, 2024 10:00
@slowli slowli added this pull request to the merge queue Apr 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2024
@AnastasiiaVashchuk AnastasiiaVashchuk added this pull request to the merge queue Apr 17, 2024
Merged via the queue into main with commit 8ab2488 Apr 17, 2024
34 checks passed
@AnastasiiaVashchuk AnastasiiaVashchuk deleted the anastasiia-extract-block-reverter branch April 17, 2024 10:56
RomanBrodetski pushed a commit that referenced this pull request Apr 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[23.1.0](core-v23.0.0...core-v23.1.0)
(2024-04-22)


### Features

* **en:** Add boxed L2 client and use it in DI
([#1627](#1627))
([9948187](9948187))
* Extract block_reverter into separate crate
([#1632](#1632))
([8ab2488](8ab2488))
* Extract house keeper into separate crate
([#1685](#1685))
([f6f49b7](f6f49b7))
* remove enum index migration
([#1734](#1734))
([13c0f52](13c0f52))
* **state-keeper:** miniblock max payload size (BFT-417)
([#1284](#1284))
([a3c8e81](a3c8e81))


### Bug Fixes

* **en:** Fix miscellaneous snapshot recovery nits
([#1701](#1701))
([13bfecc](13bfecc))
* ensure two connections for both executor and async catchup
([#1755](#1755))
([3b14a9f](3b14a9f))
* made consensus store certificates asynchronously from statekeeper
([#1711](#1711))
([d1032ab](d1032ab))
* **merkle_tree:** don't panic in `BlockOutputWithProofs::verify_proofs`
([#1717](#1717))
([a44fac9](a44fac9))
* **types:** fix LegacyCall type
([#1739](#1739))
([712919f](712919f))


### Performance Improvements

* **en:** Monitor recovery latency by stage
([#1725](#1725))
([d7efdd5](d7efdd5))


### Reverts

* **env:** Remove `ZKSYNC_HOME` env var from server
([#1713](#1713))
([aed23e1](aed23e1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: perekopskiy <mikeson.dp@gmail.com>
Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants