fix(merkle_tree): don't panic in BlockOutputWithProofs::verify_proofs
#1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed action fixed with #1720 |
slowli
reviewed
Apr 18, 2024
haraldh
force-pushed
the
verify_proofs
branch
4 times, most recently
from
06ccb6a
to
2acff25
Compare
and rather return a `Result`, so it can be used by other components. Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
slowli
approved these changes
Apr 18, 2024
RomanBrodetski
pushed a commit
that referenced
this pull request
Apr 22, 2024
🤖 I have created a release *beep* *boop* --- ## [23.1.0](core-v23.0.0...core-v23.1.0) (2024-04-22) ### Features * **en:** Add boxed L2 client and use it in DI ([#1627](#1627)) ([9948187](9948187)) * Extract block_reverter into separate crate ([#1632](#1632)) ([8ab2488](8ab2488)) * Extract house keeper into separate crate ([#1685](#1685)) ([f6f49b7](f6f49b7)) * remove enum index migration ([#1734](#1734)) ([13c0f52](13c0f52)) * **state-keeper:** miniblock max payload size (BFT-417) ([#1284](#1284)) ([a3c8e81](a3c8e81)) ### Bug Fixes * **en:** Fix miscellaneous snapshot recovery nits ([#1701](#1701)) ([13bfecc](13bfecc)) * ensure two connections for both executor and async catchup ([#1755](#1755)) ([3b14a9f](3b14a9f)) * made consensus store certificates asynchronously from statekeeper ([#1711](#1711)) ([d1032ab](d1032ab)) * **merkle_tree:** don't panic in `BlockOutputWithProofs::verify_proofs` ([#1717](#1717)) ([a44fac9](a44fac9)) * **types:** fix LegacyCall type ([#1739](#1739)) ([712919f](712919f)) ### Performance Improvements * **en:** Monitor recovery latency by stage ([#1725](#1725)) ([d7efdd5](d7efdd5)) ### Reverts * **env:** Remove `ZKSYNC_HOME` env var from server ([#1713](#1713)) ([aed23e1](aed23e1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: perekopskiy <mikeson.dp@gmail.com> Co-authored-by: perekopskiy <53865202+perekopskiy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
don't panic in
BlockOutputWithProofs::verify_proofsand rather return aResultWhy ❔
So
BlockOutputWithProofs::verify_proofscan be used by other components.Checklist
zk fmtandzk lint.zk spellcheck.zk linkcheck.