Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(reth): use reth instead of geth #1410

Merged
merged 20 commits into from
Mar 14, 2024
Merged

fix(reth): use reth instead of geth #1410

merged 20 commits into from
Mar 14, 2024

Conversation

Deniallugo
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@Deniallugo
add base path to constants
6fc4798 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Merge branch 'main' into deniallugo-fixes-for-zk-toolbox
c5e33fc
@Deniallugo
Use reth instead of geth
63f8812 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Update private keys
ce48143 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Use reth instead of geth
a968dd6 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Merge branch 'main' into deniallugo-fixes-for-zk-toolbox
72b0cf9
@Deniallugo
attempts to fix
f9ef9b6 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Update contracts
bcf3168 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Fix chain id
807891c 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Small fixes
986ad71 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
try approcah from en
8194a36 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
fix(reth): Use old version of genesis file
47b04b4 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Use geth config instead of reth config
c2f2333 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Fix lints
1cd16d2 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo Deniallugo marked this pull request as ready for review March 12, 2024 12:35
@Deniallugo
Add down into init
e1ede37 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
More fixes
e85b9d6 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo Deniallugo force-pushed the deniallugo-use-old-genesis-with-reth branch from d09f88d to e85b9d6 Compare March 12, 2024 13:01
popzxc
popzxc reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

core/lib/eth_client/src/clients/http/query.rs Outdated Show resolved Hide resolved
@Deniallugo
Copy link
Contributor Author

The current problem is on reth side.
paradigmxyz/reth#7111
Waiting this pr to be merged

@Deniallugo
Remove cludge with pending
5a29375 
Signed-off-by: Danil <deniallugo@gmail.com>
popzxc
popzxc reviewed Mar 13, 2024
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

docker-compose-gpu-runner-cuda-12-0.yml Outdated Show resolved Hide resolved
docker-compose-gpu-runner-cuda-12-0.yml Outdated Show resolved Hide resolved
@Deniallugo
Update reth
e9b2cc1 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo Deniallugo requested a review from popzxc March 13, 2024 21:38
@Deniallugo
Add readme for reth genesis
aeb7c15 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo Deniallugo force-pushed the deniallugo-use-old-genesis-with-reth branch 2 times, most recently from 322405f to e5b8735 Compare March 13, 2024 22:32
@Deniallugo Deniallugo changed the title fix(reth): use old genesis with reth fix(reth): use reth instead of geth Mar 13, 2024
popzxc
popzxc reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

core/lib/eth_client/src/clients/http/query.rs Outdated Show resolved Hide resolved
@Deniallugo
Add fallback
4cdaa45 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo Deniallugo force-pushed the deniallugo-use-old-genesis-with-reth branch from e5b8735 to 4cdaa45 Compare March 14, 2024 07:12
@Deniallugo Deniallugo requested a review from popzxc March 14, 2024 07:13
@Deniallugo Deniallugo added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit bd98dc7 Mar 14, 2024
36 checks passed
@Deniallugo Deniallugo deleted the deniallugo-use-old-genesis-with-reth branch March 14, 2024 07:55
@zksync-era-bot zksync-era-bot mentioned this pull request Mar 14, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 22, 2024
@zksync-era-bot
chore(main): release core 22.0.0 (#1424)
14a8b78 
🤖 I have created a release *beep* *boop*
---


##
[22.0.0](core-v21.1.0...core-v22.0.0)
(2024-03-21)


### ⚠ BREAKING CHANGES

* Use protocol version v22 as latest
([#1432](#1432))

### Features

* add docs for Dal
([#1273](#1273))
([66ceb0b](66ceb0b))
* adds debug_traceBlockByNumber.callFlatTracer
([#1413](#1413))
([d2a5e36](d2a5e36))
* **api:** introduce mempool cache
([#1460](#1460))
([c5d6c4b](c5d6c4b))
* **commitment-generator:** `events_queue` shadow mode
([#1138](#1138))
([9bb47fa](9bb47fa))
* **contract-verifier:** Allow sc code reverification
([#1455](#1455))
([5a37b42](5a37b42))
* **database:** add an optional master replica max connections settings
([#1472](#1472))
([e5c8127](e5c8127))
* **db:** Configurable maximum number of open RocksDB files
([#1401](#1401))
([b00c052](b00c052))
* **en:** Check recipient contract and function selector in consistency
checker ([#1367](#1367))
([ea5c684](ea5c684))
* Follow-up for DAL split
([#1464](#1464))
([c072288](c072288))
* **node_framework:** Ergonomic improvements
([#1453](#1453))
([09b6887](09b6887))
* **node_framework:** Only store each wiring layer once
([#1468](#1468))
([4a393dc](4a393dc))
* **node_framework:** Support for preconditions and oneshot tasks
([#1398](#1398))
([65ea881](65ea881))
* **node-framework:** Add eth sender layer
([#1390](#1390))
([0affdf8](0affdf8))
* **node-framework:** Add housekeeper layer
([#1409](#1409))
([702e739](702e739))
* Remove batch dry_run
([#1076](#1076))
([b82d093](b82d093))
* Separate Prover and Server DAL
([#1334](#1334))
([103a56b](103a56b))
* **storage:** Make the storage caches task cancellation aware
([#1430](#1430))
([ab532bb](ab532bb))
* support running consensus from snapshot (BFT-418)
([#1429](#1429))
([f9f4d38](f9f4d38))
* **tx-sender:** Limit concurrent tx submissions
([#1473](#1473))
([4bdf3ca](4bdf3ca))
* Use protocol version v22 as latest
([#1432](#1432))
([1757412](1757412))
* **vm:** Prestate tracer implementation
([#1306](#1306))
([c36be65](c36be65))


### Bug Fixes

* **core:** drop correct index of proof_generation_details table during
database migration
([#1199](#1199))
([76a6821](76a6821))
* **dal:** correct `tx_index_in_l1_batch` in
`get_vm_events_for_l1_batch`
([#1463](#1463))
([8bf37ac](8bf37ac))
* **node_framework:** Fix main node example
([#1470](#1470))
([ac4a744](ac4a744))
* **protocol:** Remove verifier address from protocol upgrade
([#1443](#1443))
([90dee73](90dee73))
* **reth:** use reth instead of geth
([#1410](#1410))
([bd98dc7](bd98dc7))
* **verified sources fetcher:** Use correct `contact_name` for
`SolSingleFile`
([#1433](#1433))
([0764227](0764227))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
montekki pushed a commit that referenced this pull request Mar 22, 2024
@zksync-era-bot @montekki
chore(main): release core 22.0.0 (#1424)
9b35900 
🤖 I have created a release *beep* *boop*
---


##
[22.0.0](core-v21.1.0...core-v22.0.0)
(2024-03-21)


### ⚠ BREAKING CHANGES

* Use protocol version v22 as latest
([#1432](#1432))

### Features

* add docs for Dal
([#1273](#1273))
([66ceb0b](66ceb0b))
* adds debug_traceBlockByNumber.callFlatTracer
([#1413](#1413))
([d2a5e36](d2a5e36))
* **api:** introduce mempool cache
([#1460](#1460))
([c5d6c4b](c5d6c4b))
* **commitment-generator:** `events_queue` shadow mode
([#1138](#1138))
([9bb47fa](9bb47fa))
* **contract-verifier:** Allow sc code reverification
([#1455](#1455))
([5a37b42](5a37b42))
* **database:** add an optional master replica max connections settings
([#1472](#1472))
([e5c8127](e5c8127))
* **db:** Configurable maximum number of open RocksDB files
([#1401](#1401))
([b00c052](b00c052))
* **en:** Check recipient contract and function selector in consistency
checker ([#1367](#1367))
([ea5c684](ea5c684))
* Follow-up for DAL split
([#1464](#1464))
([c072288](c072288))
* **node_framework:** Ergonomic improvements
([#1453](#1453))
([09b6887](09b6887))
* **node_framework:** Only store each wiring layer once
([#1468](#1468))
([4a393dc](4a393dc))
* **node_framework:** Support for preconditions and oneshot tasks
([#1398](#1398))
([65ea881](65ea881))
* **node-framework:** Add eth sender layer
([#1390](#1390))
([0affdf8](0affdf8))
* **node-framework:** Add housekeeper layer
([#1409](#1409))
([702e739](702e739))
* Remove batch dry_run
([#1076](#1076))
([b82d093](b82d093))
* Separate Prover and Server DAL
([#1334](#1334))
([103a56b](103a56b))
* **storage:** Make the storage caches task cancellation aware
([#1430](#1430))
([ab532bb](ab532bb))
* support running consensus from snapshot (BFT-418)
([#1429](#1429))
([f9f4d38](f9f4d38))
* **tx-sender:** Limit concurrent tx submissions
([#1473](#1473))
([4bdf3ca](4bdf3ca))
* Use protocol version v22 as latest
([#1432](#1432))
([1757412](1757412))
* **vm:** Prestate tracer implementation
([#1306](#1306))
([c36be65](c36be65))


### Bug Fixes

* **core:** drop correct index of proof_generation_details table during
database migration
([#1199](#1199))
([76a6821](76a6821))
* **dal:** correct `tx_index_in_l1_batch` in
`get_vm_events_for_l1_batch`
([#1463](#1463))
([8bf37ac](8bf37ac))
* **node_framework:** Fix main node example
([#1470](#1470))
([ac4a744](ac4a744))
* **protocol:** Remove verifier address from protocol upgrade
([#1443](#1443))
([90dee73](90dee73))
* **reth:** use reth instead of geth
([#1410](#1410))
([bd98dc7](bd98dc7))
* **verified sources fetcher:** Use correct `contact_name` for
`SolSingleFile`
([#1433](#1433))
([0764227](0764227))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

@perekopskiy perekopskiy perekopskiy approved these changes

@montekki montekki Awaiting requested review from montekki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Deniallugo @popzxc @perekopskiy