fix(chain_spec): Set correct paris block and chain difficulty #7111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil <deniallugo@gmail.com>
mattsse
requested changes
Mar 12, 2024
Deniallugo
force-pushed
the
set-correct-paris-block-and-difficulty
branch
from
91bb5df
to
b5400fe
Compare
|
Hi @mattsse thanks for the fast review! |
onbjerg
approved these changes
Mar 12, 2024
Signed-off-by: Danil <deniallugo@gmail.com>
Deniallugo
force-pushed
the
set-correct-paris-block-and-difficulty
branch
from
7fca173
to
4083f1a
Compare
6 tasks
mattsse
approved these changes
Mar 12, 2024
0xSt1ng3R
added a commit
to 0xSt1ng3R/reth
that referenced
this pull request
Mar 12, 2024
fix(chain_spec): Set correct paris block and chain difficulty (paradigmxyz#7111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's impossible to set Paris block and chain difficulty using the custom spec and ChainConfig builder.
Even if Paris has been mentioned in spec it's always disabled