GH-2992 - Drag drop card to groups doesn't work #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbishel
requested review from
Pinjasaur,
Rajat-Dabade and
harshilsharma63
and removed request for
a team,
Pinjasaur and
Rajat-Dabade
harshilsharma63
approved these changes
May 24, 2022
harshilsharma63
added
3: Reviews Complete
|
@sbishel do we also need to cherrypick this for 7.0? |
No, this was only an issue in v7.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dragging a card from one group to anther and then dragging back to the original group did now work because OnDropToCard did not get updated when cards collection changed. Therefore is was using the old collection and thus had its group to original group.
Ticket Link
Fixes #2992