Make examples directly linkable from docs #326
Conversation
…dapps into lev-MM-43004-reinstall
levb
added
2: Dev Review
levb
removed
2: Dev Review
There was a problem hiding this comment.
Nice restructure @levb. Left some comments for you, feel free to ping me on this if more comes up.
I'll keep this PR in mind when I do any future restructuring on the JS examples, as part of my upcoming PR to utilize the MM /dev docker setup.
|
|
||
| The app runs on port `4000`. | ||
|
|
||
| ## Install the app to Mattermost |
There was a problem hiding this comment.
@cwarnermm To your comment above: not necessarily. If we direct them towards using the Docker we'll have configured in /dev with their own docker container (see my other comment above). In that case, the connections will come from docker-container-name (e.g., my-app) instead of localhost and Mattermost won't have an issue with that.
| make dist-aws | ||
| ``` | ||
|
|
||
| This will create a `./dist/bundle-aws.zip` file containg the AWS-deployable app bundle. Follow the steps in [Admin's Guide](https://developers.mattermost.com/integrate/apps/deploy/deploy-aws) to setup your `appsctl` environment and initialize the AWS resources with `appsctl aws init` command. Then execute |
There was a problem hiding this comment.
The linked guide is ~7 months old, have there been any reports of issues with it or planned changes? Just wanted to get a scope on that as part of this. If no one has tested the instructions in a while, it would be nice to run through that guide then this new one to make sure it all works together.
There was a problem hiding this comment.
Just closing the loop, I finished the above task over on this Jira ticket.
* fixed the test app * Updated to server v7.2 * go mod tidy * try release 7.1 * try 1 * try 2 * try 3 * try 4 * try 5 * try 6
…termost-plugin-apps into lev-hello-docs
|
Does this PR need a rebase? |
|
@levb What are the implications of closing this? Is the intention to support this eventually? |
hanzei
added
Invalid
See also mattermost/mattermost-developer-documentation#1061