Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MessageHasBeenDeleted hook demo #165

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

jespino
Copy link
Member

@jespino jespino commented Aug 25, 2023

No description provided.

@jespino jespino requested a review from hanzei as a code owner August 25, 2023 14:37
@jespino
Copy link
Member Author

jespino commented Aug 25, 2023

Closing this in favor of #159

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation of this PR is a bit better then #159.

Let's merge it 🚀

@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Aug 30, 2023
@hanzei hanzei added this to the v0.10.0 milestone Aug 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05% ⚠️

Comparison is base (a269113) 2.03% compared to head (429b709) 1.99%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #165      +/-   ##
=========================================
- Coverage    2.03%   1.99%   -0.05%     
=========================================
  Files          14      14              
  Lines        1769    1805      +36     
=========================================
  Hits           36      36              
- Misses       1731    1767      +36     
  Partials        2       2              
Files Changed Coverage Δ
server/message_hooks.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jespino
Copy link
Member Author

jespino commented Sep 11, 2023

/update-branch

@jespino jespino merged commit 726829b into mattermost:master Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants